lightning: support disable scheduler by key range #34130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
do-not-merge/needs-linked-issue
release-note-none
sleepymole
force-pushed
the
online-import
branch
from
5d895e0
to
0189e15
Compare
|
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/ba5df76ffce53b6f749694bc76be682b3a359e8f |
sleepymole
added
the
component/lightning
sleepymole
commented
Apr 21, 2022
sleepymole
force-pushed
the
online-import
branch
2 times, most recently
from
5d9341b
to
4e3adcc
Compare
sleepymole
force-pushed
the
online-import
branch
3 times, most recently
from
55d5687
to
886cde5
Compare
sleepymole
force-pushed
the
online-import
branch
2 times, most recently
from
621a0b8
to
38d1f26
Compare
ti-chi-bot
added
size/XL
sleepymole
changed the title
ti-chi-bot
removed
the
do-not-merge/work-in-progress
|
/run-integration-br-test |
sleepymole
force-pushed
the
online-import
branch
from
c3f1e52
to
2c7bc6e
Compare
ti-chi-bot
added
the
needs-rebase
ti-chi-bot
removed
the
needs-rebase
sleepymole
force-pushed
the
online-import
branch
from
43fec6b
to
f340e89
Compare
|
/run-integration-br-test |
lichunzhu
reviewed
Jun 23, 2022
Comment on lines
+345
to
347
| zap.Error(err)) | ||
| } | ||
| return nil |
There was a problem hiding this comment.
Do we need to handle this error?
There was a problem hiding this comment.
Emm, it's hard to say. Until now, we didn't treat scatter region error as a critical error.
| @@ -478,13 +481,9 @@ func (local *local) checkScatterRegionFinishedOrReScatter(ctx context.Context, r | |||
| if respErr.GetType() == pdpb.ErrorType_REGION_NOT_FOUND { | |||
| return true, nil | |||
| } | |||
| // don't return error if region replicate not complete | |||
There was a problem hiding this comment.
We don't need to handle this error now, do we?
There was a problem hiding this comment.
It is moved to retriable errors.
There was a problem hiding this comment.
oh, it's caught by the caller.
Co-authored-by: Obliviate <[email protected]>
buchuitoudegou
approved these changes
Jun 24, 2022
| @@ -478,13 +481,9 @@ func (local *local) checkScatterRegionFinishedOrReScatter(ctx context.Context, r | |||
| if respErr.GetType() == pdpb.ErrorType_REGION_NOT_FOUND { | |||
| return true, nil | |||
| } | |||
| // don't return error if region replicate not complete | |||
There was a problem hiding this comment.
oh, it's caught by the caller.
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: c27bcf8
|
ti-chi-bot
added
the
status/can-merge
TiDB MergeCI notify
|
morgo
added a commit
to morgo/tidb
that referenced
this pull request
Jun 24, 2022
* upstream/master: (38 commits) planner: disable collate clause support for enum or set column (pingcap#35684) *: Provide a util to "pause" session in uint test (pingcap#35529) ddl: implement the core for multi-schema change (pingcap#35429) parser: XXXDatabaseStmt now use CIStr for DB name (pingcap#35668) *: remove real tikv test on github actions (pingcap#35710) lightning: support disable scheduler by key range (pingcap#34130) Revert "planner: fix the wrong cost formula of MPPExchanger" (pingcap#35707) ddl, owner: refresh ddl sequence cache after becoming the owner (pingcap#35516) store/copr: fix tiflash integration test by disable paging on tiflash (pingcap#35674) planner: new cost formula for IndexJoin (pingcap#35671) BR: fix backup ranges total time summary log (pingcap#35552) raw_restore: fix the issue that raw restore rewrite the t prefix keys (pingcap#35641) table: fix cannot find the temp table when it's created in a transaction (pingcap#35663) metrics: replace histogram with counter for DistSQLCoprCache (pingcap#35514) *: enable exportloopref (pingcap#35680) types: fix bad error message for numeric conversion issue#32744 (pingcap#34047) *: enable ineffassign (pingcap#35670) config, sysvar: map `max-server-connections` to `max_connections` (pingcap#35453) *: enable durationcheck for nogo linter (pingcap#35661) *: fix issue of cast string as time is incompatible with MySQL (pingcap#35455) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #35148
Problem Summary:
We want to use lightning to import data to an online cluster. To reduce the impact on online services, lightning shouldn't disable the whole scheduler during importing. Instead, lightning should only disable the scheduler on the region that is being imported.
What is changed and how it works?
tikv/pd#4695 supported ttl for region label. We can use the region label to disable scheduler on specific key range, and recover scheduler automatically.
Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.