Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: enable all gosimples #35762

Merged
merged 5 commits into from
Jun 29, 2022
Merged

*: enable all gosimples #35762

merged 5 commits into from
Jun 29, 2022

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jun 28, 2022 •
edited
Loading

Signed-off-by: Weizhen Wang [email protected]

What problem does this PR solve?

Issue Number: ref #35345

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 28, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tangenta
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 28, 2022
@hawkingrei hawkingrei mentioned this pull request Jun 28, 2022
Closed
7 tasks
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 28, 2022
@sluongng
Copy link

https://github.com/sluongng/nogo-analyzer/blob/3aba8ac6041c8a6d88167819e887b7e8cbbe6d24/def.bzl#L3 use this

@hawkingrei
Copy link
Member Author

https://github.com/sluongng/nogo-analyzer/blob/3aba8ac6041c8a6d88167819e887b7e8cbbe6d24/def.bzl#L3 use this

Great Idea.

@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 28, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jun 28, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/fe110b13a33257782aaee3b65c601533de54334d

@hawkingrei
*: enable all gosimples
7f9cbe1 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei hawkingrei requested a review from xhebox June 28, 2022 12:25
@hawkingrei
Copy link
Member Author

https://github.com/sluongng/nogo-analyzer/blob/3aba8ac6041c8a6d88167819e887b7e8cbbe6d24/def.bzl#L3 use this

I will create another pr to solve it.

@hawkingrei
Copy link
Member Author

/run-check_dev_2

2 similar comments
@hawkingrei
Copy link
Member Author

/run-check_dev_2

@hawkingrei
Copy link
Member Author

/run-check_dev_2

xhebox
xhebox reviewed Jun 28, 2022
View reviewed changes
expression/builtin_compare.go
Comment on lines 2556 to 2560
if arg0 < 0 {
break
return res, false, nil
}
if types.CompareInt64(arg0, arg1) == 0 {
res = 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These patterns feels even more weird than before. Some code directly return in the switch block, and some relies on return ... at the very end of the function. What do you think?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

break in the switch is so weird. it has two way to fix it.

1、diectly replace with return
2、remove this switch branch. some of switch branch is useless.
3、refactor the code

I do minimal changes to keep code review easy. but I think it still needs to improve.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, Adding break in the switch is a code style of C/C++？

Copy link
Contributor

@xhebox xhebox Jun 29, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, Adding break in the switch is a code style of C/C++？

Of course. Since case in c/cpp will fall-through by default, so it is natural to use break everywhere. It is a like return for switch block.

Go does not need to use break every case, but you can still use break to "return from the switch block". So when you "jump out of the/return from" switch block, the execution continues from the code below the switch block.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change is fine because the code is simple enough.

@hawkingrei
*: enable all gosimples
fbcee79 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
*: enable all gosimples
070c4e0 
Signed-off-by: Weizhen Wang <[email protected]>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 29, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 29, 2022
@xhebox
Copy link
Contributor

xhebox commented Jun 29, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 070c4e0

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 29, 2022
@ti-chi-bot ti-chi-bot merged commit c610388 into pingcap:master Jun 29, 2022
@hawkingrei hawkingrei deleted the enable_simple branch June 29, 2022 08:36
morgo added a commit to morgo/tidb that referenced this pull request Jun 29, 2022
@morgo
Merge remote-tracking branch 'upstream/master' into remove-hidden-sys…
a104dff 
…vars

* upstream/master: (28 commits)
  *: enable unconvert (pingcap#35821)
  log-backup: check timezone when using datatime format ts string (pingcap#35811)
  planner: support the leading hint for outer join (pingcap#35264)
  lightning: revert new policy of allocating rowid and refine it later (pingcap#35817)
  txn: manage the initialization of RCCheckTS by transaction context provider (pingcap#35554)
  ddl: make output field name in `show tables/databases stmt` compatible with mysql (pingcap#35136)
  txn: remove `legacy.SimpleTxnContextProvider` (pingcap#35667)
  txn: fix the error message if retry could not be used for rc check ts (pingcap#35474)
  *: support canceling DDL statements with KILL (pingcap#35803)
  lightning: avoid extracting db schema when schema file is not provided (pingcap#35783)
  *: enable all gosimples (pingcap#35762)
  tools/check: skip 'tests' directory in 'make ut' (pingcap#35800)
  metrics: add loading region cache duration (pingcap#34679)
  ddl: DROP TABLE/VIEW/SEQUENCE now use XXXStmt as parameter (pingcap#35741)
  types: fix incompatible implementation of jsonpath extraction (pingcap#35320)
  planner: fix TRACE PLAN TARGET = 'estimation' panic when meeting partition table (pingcap#35743)
  *: Add `testfork.RunTest` to run multiple tests in one function (pingcap#35746)
  sessionctx/variable: add tests to ensure skipInit can be removed (pingcap#35703)
  helper: request another PD if one of them is unavailable (pingcap#35750)
  metrics: add cached table related metrics to grafana panel (pingcap#34718)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhebox xhebox xhebox approved these changes

@tisonkun tisonkun tisonkun approved these changes

@tangenta tangenta tangenta approved these changes

@xiongjiwei xiongjiwei Awaiting requested review from xiongjiwei

@LittleFall LittleFall Awaiting requested review from LittleFall

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@hawkingrei @ti-chi-bot @sluongng @sre-bot @xhebox @tisonkun @tangenta