Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statistics: fix "Invalid xxx character string" error when loading new collation stats #36709

Merged
merged 6 commits into from
Jul 29, 2022
Merged

statistics: fix "Invalid xxx character string" error when loading new collation stats #36709

merged 6 commits into from
Jul 29, 2022

Conversation

time-and-fate
Copy link
Member

What problem does this PR solve?

Issue Number: close #35208

What is changed and how it works?

#33146 didn't fix the loading new collation stats issues fully.

In this PR, we fix it again as we did in #27033.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 29, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Reminiscent
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added needs-cherry-pick-6.0 release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 29, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 29, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/1b00cd9ea1cab0bd0402449cdecec5f7997471a3

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 29, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 29, 2022
@time-and-fate
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5102cd2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 29, 2022
@time-and-fate
Copy link
Member Author

/run-mysql-test tidb-test=pr/1895

@time-and-fate
Copy link
Member Author

/run-mysql-test tidb-test=pr/1895

@qw4990
Copy link
Contributor

qw4990 commented Jul 29, 2022

/merge

@time-and-fate
Copy link
Member Author

/run-mysql-test tidb-test=pr/1895

1 similar comment
@time-and-fate
Copy link
Member Author

/run-mysql-test tidb-test=pr/1895

@ti-chi-bot ti-chi-bot merged commit 9cf1c34 into pingcap:master Jul 29, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 29, 2022
@time-and-fate @ti-srebot
cherry pick pingcap#36709 to release-6.1
5f637a6 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Jul 29, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.1 in PR #36723

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 29, 2022
@time-and-fate @ti-srebot
cherry pick pingcap#36709 to release-6.2
fdee2e1 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Jul 29, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.2 in PR #36724

@sre-bot
Copy link
Contributor

sre-bot commented Jul 29, 2022

TiDB MergeCI notify

🔴 Bad News! [2] CI still failing after this pr merged.
These failed integration tests don't seem to be introduced by the current PR.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/common-test 🔴 failed 2, success 9, total 11 21 min Existing failure
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 9, success 8, total 17 21 min Existing failure
idc-jenkins-ci/integration-cdc-test 🟢 all 36 tests passed 30 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 10 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 9 min 44 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 9 min 34 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 9 min 14 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 9 min 7 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 8 min 51 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

ti-chi-bot pushed a commit that referenced this pull request Jul 29, 2022
@ti-srebot
statistics: fix "Invalid xxx character string" error when loading new…
78f5732 
… collation stats (#36709) (#36724)

close #35208
qw4990 pushed a commit to qw4990/tidb that referenced this pull request Aug 1, 2022
@time-and-fate @qw4990
statistics: fix "Invalid xxx character string" error when loading new…
9d42eab 
… collation stats (pingcap#36709)

close pingcap#35208
ti-chi-bot pushed a commit that referenced this pull request Aug 20, 2022
@ti-srebot
statistics: fix "Invalid xxx character string" error when loading new…
21e40f4 
… collation stats (#36709) (#36723)

close #35208
@time-and-fate time-and-fate mentioned this pull request Aug 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reminiscent Reminiscent Reminiscent approved these changes

@winoros winoros winoros approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

load-stats statements return an error when column collate is utf8mb4_unicode_ci
7 participants
@time-and-fate @ti-chi-bot @sre-bot @qw4990 @ti-srebot @winoros @Reminiscent