schematracker: treat TableInfo as immutable #39103
Conversation
Signed-off-by: lance6716 <[email protected]>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
ddl/schematracker/dm_tracker.go
Outdated
| tblInfo, err := d.TableByName(ti.Schema, ti.Name) | ||
| if err != nil { | ||
| return errors.Trace(err) | ||
| } | ||
|
|
||
| tblInfo = tblInfo.Clone() | ||
| defer func() { | ||
| if err == nil { | ||
| _ = d.PutTable(ti.Schema, tblInfo) | ||
| } | ||
| }() | ||
|
|
There was a problem hiding this comment.
this part code has many same parts in the file.
Signed-off-by: lance6716 <[email protected]>
|
ptal @GMHDBJD @CharlesCheung96 |
|
/cc @gozssky |
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: e896b64
|
ti-chi-bot
added
the
status/can-merge
TiDB MergeCI notify🔴 Bad News! New failing [1] after this pr merged.
|
Signed-off-by: lance6716 [email protected]
What problem does this PR solve?
Issue Number: ref #35933
Problem Summary:
before this PR, DM needs to clone the TableInfo after reading in order to avoid data race with SchemaTracker, but that consumes much memory. After this PR TableInfo is immutable so no need to clone it.
What is changed and how it works?
before SchemaTracker will modify a TableInfo, it will clone it first. After the modification, it will put it to InfoStore.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.