syncer(dm): update dep to remove clone for TableInfo

[lance6716]

Signed-off-by: lance6716 [email protected]

What problem does this PR solve?

Issue Number: ref #4287

What is changed and how it works?

in the old PR, I'm afraid that TableInfo is changing by SchemaTracker when DMLWorker is accesing, so I clone it before assign it to DMLWorker. But seems DML and DDL job will not be processed simutaneously, this clone is not needed.

Check List

Tests

• pass original test

Questions

Will it cause performance regression or break compatibility?

Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• D3Hunter
• okJiang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[lance6716]

/cc @GMHDBJD @CharlesCheung96
/run-dm-integration-test

[lance6716]

/run-engine-integration-test

[lance6716]

/hold

[lance6716]

/run-dm-integration-test

[lance6716]

/unhold

[lance6716]

/cc @okJiang @GMHDBJD @CharlesCheung96

[okJiang]

I don't find where changes the tableInfo😂, can you give an example? BTW, related problem about version updating is fixed in #7584.

[lance6716]

TableInfo is changed in SchemaTracker when handling DDL, pingcap/tidb#39103

An example: TableInfo is read by checkpoint component as a "flushed TableInfo", and when task has error, checkpoint will use flushed TableInfo to rollback some changes. If the TableInfo is mutable, flushed TableInfo may be modified after a DDL
is applied in SchemaTracker, rolling back logic is wrong.

[codecov-commenter]

Codecov Report

Merging #7590 (ddfa2bd) into master (0438dd4) will decrease coverage by 0.0448%.
The diff coverage is 34.4110%.

Additional details and impacted files

Flag	Coverage Δ
cdc	66.7767% <34.4186%> (-0.1401%)	⬇️
engine	63.7810% <0.0000%> (-0.0051%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #7590        +/-   ##
================================================
- Coverage   60.0458%   60.0010%   -0.0449%     
================================================
  Files           807        807                
  Lines         92391      92450        +59     
================================================
- Hits          55477      55471         -6     
- Misses        32099      32157        +58     
- Partials       4815       4822         +7     

[lance6716]

ptal @CharlesCheung96 @GMHDBJD @okJiang

[lance6716]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: ddfa2bd

[ti-chi-bot]

@lance6716: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.