Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Reorganize Partition DDL states logic #40473

Merged
merged 786 commits into from
Jan 18, 2023
Merged

*: Reorganize Partition DDL states logic #40473

merged 786 commits into from
Jan 18, 2023

Conversation

mjonss
Copy link
Contributor

@mjonss mjonss commented Jan 10, 2023

What problem does this PR solve?

Issue Number: ref #38535

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

YangKeao and others added 30 commits December 13, 2022 14:28
@YangKeao
ttl, variables: add system variables for ttl job schedule (pingcap#39727
621115b 
)

close pingcap#39725
@lcwangchao
*: fix slow query nil pointer panic when get session for TTL (pingcap…
b7e21a0 
…#39865)

close pingcap#39864
@lcwangchao
ttl: Add metrics for TTL (pingcap#39849)
cb435fe 
close pingcap#39848
@Yisaer
statistics: support gc outdated historical stats (pingcap#39788)
760dbe1
@qw4990
planner: rename general plan cache to non-prepared plan cache (pi…
aeceb22 
…ngcap#39873)
@qw4990
planner: rename 'tidb_enable_general_plan_cache' and 'tidb_general_pl…
1ab88f2 
…an_cache_size' to 'tidb_enable_non_prepared_plan_cache' and 'tidb_non_prepared_plan_cache_size'
@fzzf678
planner: binding from cluster statements summary (pingcap#39737)
509fe6d 
ref pingcap#39199
@lcwangchao
ttl: modify default value of tidb_ttl_delete_batch_size to 100 (pin…
c4047cc 
…gcap#39878)

close pingcap#39877
@tangenta
ddl: close lightning writers after the import is complete (pingcap#39879
90a7398 
)

close pingcap#39800
@you06
store/copr: handle region error from client (pingcap#39838)
d0d6955 
ref pingcap#39361
@YangKeao
ttl: fix scan workers shrink (pingcap#39860)
827d8ff 
close pingcap#39859
@mamil
docs: fix typos (pingcap#39870)
222faa4
@Yisaer
domain: support dump sql meta in plan replayer (pingcap#39863)
4b3a442 
close pingcap#39883
@TonsnakeLin
SlowLog: Update Wait_TS field in slow log for every sql (pingcap#39843
1e7c6dd 
)

close pingcap#39713
@zimulala
session: fix a bug for InitDDLJobTables (pingcap#39861)
98cef5a 
ref pingcap#39854
@YangKeao
ttl: reschedule scan tasks after update task state (pingcap#39891)
d2eca72 
close pingcap#39890
@lcwangchao
ttl: TTL support split scan ranges for some primary key with more tha…
4a19cae 
…n one columns (pingcap#39896)

close pingcap#39895
@hawkingrei
*: add dependabot (pingcap#39229)
ba5e85b
@xiongjiwei
expression: support json_overlaps function (pingcap#39867)
b41be06 
ref pingcap#39866
@time-and-fate
executor, planner: InitLogger before CreateMockStore in tests to …
1e7c552 
…avoid data race (pingcap#39900)

close pingcap#39892
@Yisaer
statistics: add source column for stats_meta_hisotry table (pingcap#3…
388e008 
…9835)
@lcwangchao
ttl: fix ttl txn will not return error when rolling back (pingcap#39918)
66a2e96 
close pingcap#39917
@hawkingrei
expression: close recordset (pingcap#39899)
565128e
@YuJuncen
br: make more sane variables of ticking timeout (pingcap#39887)
dd42b72 
close pingcap#39620
@xiongjiwei
expression: support member of function (pingcap#39880)
bb50e33 
ref pingcap#39866
@Leavrth
br: fix err overwrite (pingcap#39935)
e5c0b6b 
close pingcap#39934
@YangKeao
ttl: add log in the whole lifecycle of a job (pingcap#39931)
aeec193 
close pingcap#39930
@YangKeao
ttl: use optimistic transaction with 0 retry limit for ttl (pingcap#3…
de865c4 
…9924)

close pingcap#39923
@YangKeao
ttl: periodically update state for a job in heartbeat (pingcap#39939)
4ad530e 
close pingcap#39938
@fzzf678
parser: support syntax set binding status by sql digest (pingcap#39515)
62a8001 
ref pingcap#39199
@mjonss mjonss mentioned this pull request Jan 12, 2023
Closed
13 tasks
bb7133
bb7133 reviewed Jan 12, 2023
View reviewed changes
ddl/partition.go Outdated Show resolved Hide resolved
@mjonss mjonss mentioned this pull request Jan 12, 2023
Merged
12 tasks
bb7133
bb7133 approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 13, 2023
@mjonss
Copy link
Contributor Author

mjonss commented Jan 16, 2023

/retest

wjhuang2016
wjhuang2016 reviewed Jan 17, 2023
View reviewed changes
ddl/ddl_api.go Show resolved Hide resolved
ddl/ddl_api.go Outdated Show resolved Hide resolved
ddl/partition.go Show resolved Hide resolved
ddl/partition.go Show resolved Hide resolved
tiancaiamao
tiancaiamao approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@tiancaiamao tiancaiamao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please address comment from the others @mjonss

ddl/db_integration_test.go Outdated Show resolved Hide resolved
ddl/ddl_api.go Show resolved Hide resolved
ddl/ddl_api.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 17, 2023
@mjonss mjonss changed the title *: Reorganize Partition DDL states logic *: Reorganize Partition DDL states logic | tidb-test=pr/2069 Jan 17, 2023
@mjonss
Copy link
Contributor Author

mjonss commented Jan 17, 2023

/test mysql-test

@mjonss
Copy link
Contributor Author

mjonss commented Jan 18, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e620a42

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 18, 2023
@ti-chi-bot ti-chi-bot merged commit 2887591 into pingcap:feature/reorganize-partition Jan 18, 2023
@mjonss mjonss mentioned this pull request Jan 18, 2023
Closed
12 tasks
@mjonss mjonss changed the title *: Reorganize Partition DDL states logic | tidb-test=pr/2069 *: Reorganize Partition DDL states logic Jan 18, 2023
@mjonss mjonss deleted the reorg-part-ddl-states branch January 18, 2023 01:02
This was referenced Jan 31, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta left review comments

@bb7133 bb7133 bb7133 approved these changes

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.