Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store/copr: disable stale read when meeting lock for cop #44240

Merged
merged 2 commits into from
May 29, 2023
Merged

store/copr: disable stale read when meeting lock for cop #44240

merged 2 commits into from
May 29, 2023

Conversation

you06
Copy link
Contributor

@you06 you06 commented May 29, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #43659

Problem Summary:

Disable stale read after meeting lock.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

test

Test sysbench read only without point select(all queries are based on coprocessor).

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 29, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • cfzjywxk
  • zyguan

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/invalid-title release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 29, 2023
@you06 you06 changed the title disable stale read when meeting lock for cop store/copr: disable stale read when meeting lock for cop May 29, 2023
@you06 you06 requested review from zyguan and cfzjywxk May 29, 2023 07:23
@cfzjywxk cfzjywxk added type/enhancement The issue or PR belongs to an enhancement. sig/transaction SIG:Transaction labels May 29, 2023
cfzjywxk
cfzjywxk approved these changes May 29, 2023
View reviewed changes
Copy link
Contributor

@cfzjywxk cfzjywxk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cfzjywxk
cfzjywxk approved these changes May 29, 2023
View reviewed changes
Copy link
Contributor

@cfzjywxk cfzjywxk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 29, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 29, 2023
@cfzjywxk
Copy link
Contributor

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 29, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 58150ac

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 29, 2023
@you06
Copy link
Contributor Author

you06 commented May 29, 2023

/retest

@you06
bazel
5e3d1ae 
Signed-off-by: you06 <[email protected]>
@ti-chi-bot ti-chi-bot bot removed the status/can-merge Indicates a PR has been approved by a committer. label May 29, 2023
@you06
Copy link
Contributor Author

you06 commented May 29, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 29, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 5e3d1ae

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 29, 2023
@ti-chi-bot ti-chi-bot bot merged commit 10e6e42 into pingcap:master May 29, 2023
@you06
Copy link
Contributor Author

you06 commented May 29, 2023

/cherry-pick release-6.5

@ti-chi-bot ti-chi-bot mentioned this pull request May 29, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

@you06: new pull request created to branch release-6.5: #44251.

In response to this:

/cherry-pick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@you06 you06 mentioned this pull request May 29, 2023
Closed
@you06
Copy link
Contributor Author

you06 commented May 29, 2023

/cherry-pick release-7.1

@ti-chi-bot ti-chi-bot mentioned this pull request May 29, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

@you06: new pull request created to branch release-7.1: #44253.

In response to this:

/cherry-pick release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot bot pushed a commit that referenced this pull request May 29, 2023
@ti-chi-bot
store/copr: disable stale read when meeting lock for cop (#44240) (#4…
97ef067 
…4251)

close #43659
you06 added a commit to ti-chi-bot/tidb that referenced this pull request Jul 12, 2023
@you06
This is an automated cherry-pick of pingcap#44240
f8119aa 
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: you06 <[email protected]>

update go.mod

Signed-off-by: you06 <[email protected]>
ti-chi-bot bot pushed a commit that referenced this pull request Jul 12, 2023
@ti-chi-bot
store/copr: disable stale read when meeting lock for cop (#44240) (#4…
12c1cf2 
…4253)

close #43659
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfzjywxk cfzjywxk cfzjywxk approved these changes

@zyguan zyguan zyguan approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. sig/transaction SIG:Transaction size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable stale read when retry leader with keyIsLocked error
4 participants
@you06 @cfzjywxk @ti-chi-bot @zyguan