Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store/copr: disable stale read when meeting lock for cop (#44240) #44253

Merged
merged 3 commits into from
Jul 12, 2023
Merged

store/copr: disable stale read when meeting lock for cop (#44240) #44253

merged 3 commits into from
Jul 12, 2023

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #44240

What problem does this PR solve?

Issue Number: close #43659

Problem Summary:

Disable stale read after meeting lock.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

test

Test sysbench read only without point select(all queries are based on coprocessor).

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot mentioned this pull request May 29, 2023
Merged
12 tasks
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 29, 2023

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. sig/transaction SIG:Transaction size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 29, 2023
@ti-chi-bot ti-chi-bot added type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. type/enhancement The issue or PR belongs to an enhancement. labels May 29, 2023
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 29, 2023
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 5, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 15, 2023
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 12, 2023
@you06
This is an automated cherry-pick of pingcap#44240
f8119aa 
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: you06 <[email protected]>

update go.mod

Signed-off-by: you06 <[email protected]>
@you06 you06 force-pushed the cherry-pick-44240-to-release-7.1 branch from 7774136 to f8119aa Compare July 12, 2023 04:26
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 12, 2023
@you06
Copy link
Contributor

you06 commented Jul 12, 2023

/retest

@you06
update go.mod
0c6dac3 
Signed-off-by: you06 <[email protected]>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 12, 2023
@crazycs520 crazycs520 mentioned this pull request Jul 12, 2023
Closed
12 tasks
@you06
update go.mod
4fbaabc 
Signed-off-by: you06 <[email protected]>
@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 12, 2023
@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 12, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 12, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-12 04:52:25.754667733 +0000 UTC m=+480437.525006446: ☑️ agreed by crazycs520.
  • 2023-07-12 08:21:29.115947104 +0000 UTC m=+492980.886285816: ☑️ agreed by zyguan.

@you06
Copy link
Contributor

you06 commented Jul 12, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 12, 2023

@you06: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@you06
Copy link
Contributor

you06 commented Jul 12, 2023

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crazycs520, you06, zyguan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [crazycs520,you06,zyguan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 12c1cf2 into pingcap:release-7.1 Jul 12, 2023
@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Jul 24, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 24, 2023
@you06 you06 mentioned this pull request Aug 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zyguan zyguan zyguan approved these changes

@crazycs520 crazycs520 crazycs520 approved these changes

Assignees

@you06 you06

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/transaction SIG:Transaction size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @you06 @zyguan @crazycs520