Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

partition: fix index join probe side will locate partition error when it's a table range scan | tidb-test=pr/2145 (#44414) #44448

Merged
merged 5 commits into from
Jun 6, 2023
Merged

partition: fix index join probe side will locate partition error when it's a table range scan | tidb-test=pr/2145 (#44414) #44448

merged 5 commits into from
Jun 6, 2023

Conversation

AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Jun 6, 2023 •
edited
Loading

cherry-pick #44414 close #43686

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

partition: fix index join probe side will locate partition error when it's a table range scan

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 6, 2023
@ti-chi-bot ti-chi-bot bot requested review from CbcWestwolf and sdojjy June 6, 2023 09:36
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Jun 6, 2023
@AilinKid
Copy link
Contributor Author

AilinKid commented Jun 6, 2023

/LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 6, 2023

@AilinKid: you cannot LGTM your own PR.

In response to this:

/LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the approved label Jun 6, 2023
Defined2014
Defined2014 previously approved these changes Jun 6, 2023
View reviewed changes
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 6, 2023
wshwsh12
wshwsh12 previously approved these changes Jun 6, 2023
View reviewed changes
bb7133
bb7133 previously approved these changes Jun 6, 2023
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 6, 2023
@AilinKid
Copy link
Contributor Author

AilinKid commented Jun 6, 2023

/retest

@AilinKid
Copy link
Contributor Author

AilinKid commented Jun 6, 2023

/run-mysql-test

@hawkingrei
Copy link
Member

/retest

@AilinKid
test mysql -test
8715bc4 
Signed-off-by: AilinKid <[email protected]>
@AilinKid AilinKid dismissed stale reviews from bb7133, wshwsh12, and Defined2014 via 8715bc4 June 6, 2023 10:50
@ti-chi-bot ti-chi-bot bot removed the lgtm label Jun 6, 2023
@AilinKid
Copy link
Contributor Author

AilinKid commented Jun 6, 2023 •
edited
Loading

seems I have commented everything changed by this pr and the MySQL-test case is still so unstable

@AilinKid
Copy link
Contributor Author

AilinKid commented Jun 6, 2023

/retest

@AilinKid
Copy link
Contributor Author

AilinKid commented Jun 6, 2023

/retest

mjonss
mjonss reviewed Jun 6, 2023
View reviewed changes
executor/builder.go Outdated Show resolved Hide resolved
executor/partition_table_test.go Outdated Show resolved Hide resolved
@chrysan chrysan changed the title partition: fix index join probe side will locate partition error when it's a table range scan (#44414) partition: fix index join probe side will locate partition error when it's a table range scan | tidb-test=pr/2145 (#44414) Jun 6, 2023
@chrysan
Copy link
Contributor

chrysan commented Jun 6, 2023

/test mysql-test

@chrysan
Copy link
Contributor

chrysan commented Jun 6, 2023

/test unit-test

@AilinKid
restore
da1beb3 
Signed-off-by: AilinKid <[email protected]>
@AilinKid
Copy link
Contributor Author

AilinKid commented Jun 6, 2023

/LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 6, 2023

@AilinKid: you cannot LGTM your own PR.

In response to this:

/LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 6, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 6, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hawkingrei, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [AilinKid,hawkingrei,winoros]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 6, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 6, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-06 09:39:06.696344475 +0000 UTC m=+341132.969317260: ☑️ agreed by Defined2014.
  • 2023-06-06 09:43:54.002259866 +0000 UTC m=+341420.275232685: ☑️ agreed by wshwsh12.
  • 2023-06-06 10:50:14.272456392 +0000 UTC m=+1706.117090988: ✖️🔁 reset by AilinKid.
  • 2023-06-06 17:05:06.509279209 +0000 UTC m=+24198.353913794: ☑️ agreed by hawkingrei.
  • 2023-06-06 18:03:47.663458251 +0000 UTC m=+27719.508092849: ☑️ agreed by winoros.

@ti-chi-bot ti-chi-bot bot merged commit d5902d7 into pingcap:release-6.5-20230425-v6.5.2 Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjonss mjonss mjonss left review comments

@winoros winoros winoros approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

@Defined2014 Defined2014 Defined2014 left review comments

@wshwsh12 wshwsh12 wshwsh12 left review comments

@bb7133 bb7133 bb7133 left review comments

@CbcWestwolf CbcWestwolf Awaiting requested review from CbcWestwolf

@sdojjy sdojjy Awaiting requested review from sdojjy

Assignees
No one assigned
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@AilinKid @hawkingrei @chrysan @bb7133 @mjonss @winoros @wshwsh12 @Defined2014