Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client-go: update client-go to fix data race #44772

Merged
merged 2 commits into from
Jun 19, 2023
Merged

client-go: update client-go to fix data race #44772

merged 2 commits into from
Jun 19, 2023

Conversation

glorv
Copy link
Contributor

@glorv glorv commented Jun 19, 2023

What problem does this PR solve?

Issue Number: close #44758

Problem Summary:

What is changed and how it works?

Update client-go to fix the data race in RPCInterceptor, the related change in client-go is tikv/client-go#845

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 19, 2023
@glorv
Copy link
Contributor Author

glorv commented Jun 19, 2023

/check-issue-triage-complete

@glorv glorv requested a review from nolouch June 19, 2023 05:25
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 19, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 19, 2023
nolouch
nolouch approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 19, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, nolouch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 19, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 19, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-19 06:13:11.826090238 +0000 UTC m=+584588.240694313: ☑️ agreed by hawkingrei.
  • 2023-06-19 06:25:07.36618216 +0000 UTC m=+585303.780786239: ☑️ agreed by nolouch.

@ti-chi-bot ti-chi-bot bot merged commit b7773da into pingcap:master Jun 19, 2023
@glorv glorv deleted the fix-race branch June 19, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@nolouch nolouch nolouch approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DATA RACE in the RPCInterceptorChain
3 participants
@glorv @hawkingrei @nolouch