internal: fix rpc interceptor data race #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: glorv <[email protected]>
|
@Connor1996 @nolouch PTAL, thanks |
nolouch
approved these changes
Jun 19, 2023
12 tasks
iosmanthus
added a commit
that referenced
this pull request
Jun 29, 2023
Co-authored-by: disksing <[email protected]> Co-authored-by: David <[email protected]> Co-authored-by: Hu# <[email protected]> Co-authored-by: Weizhen Wang <[email protected]> Co-authored-by: you06 <[email protected]> Co-authored-by: ShuNing <[email protected]> Co-authored-by: Hu# <[email protected]> Co-authored-by: zzm <[email protected]> Co-authored-by: Yongbo Jiang <[email protected]> Co-authored-by: crazycs <[email protected]> Co-authored-by: glorv <[email protected]> Co-authored-by: zyguan <[email protected]> ResolvedTS error just write in debug log (#814) ResolvedTS error just write in debug log (#825) fix ci (#835) fix rpc interceptor data race (#845) resolver: let getTxnStatusFromLock return error when backoff timeout (#847)
iosmanthus
added a commit
that referenced
this pull request
Jun 29, 2023
Co-authored-by: disksing <[email protected]> Co-authored-by: David <[email protected]> Co-authored-by: Hu# <[email protected]> Co-authored-by: Weizhen Wang <[email protected]> Co-authored-by: you06 <[email protected]> Co-authored-by: ShuNing <[email protected]> Co-authored-by: Hu# <[email protected]> Co-authored-by: zzm <[email protected]> Co-authored-by: Yongbo Jiang <[email protected]> Co-authored-by: crazycs <[email protected]> Co-authored-by: glorv <[email protected]> Co-authored-by: zyguan <[email protected]> ResolvedTS error just write in debug log (#814) ResolvedTS error just write in debug log (#825) fix ci (#835) fix rpc interceptor data race (#845) resolver: let getTxnStatusFromLock return error when backoff timeout (#847)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: pingcap/tidb#44758
This PR changed
ChainRPCInterceptorsto always build a new interceptor to avoid data race will the original interceptor is used by other requests.