-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gomod: update pdclient to support backoff mechanism for memberLoop #46769
Conversation
9681e53
to
fadfb63
Compare
Signed-off-by: husharp <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #46769 +/- ##
================================================
- Coverage 73.2795% 72.8340% -0.4456%
================================================
Files 1330 1352 +22
Lines 397448 405934 +8486
================================================
+ Hits 291248 295658 +4410
- Misses 87588 91656 +4068
- Partials 18612 18620 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/test check-dev |
/test unit-test |
@HuSharp: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@HuSharp: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/check-issue-triage-complete |
/retest-required |
Signed-off-by: husharp <[email protected]>
release-6.5 had been updated by https://github.com/pingcap/tidb/pull/46616/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6L94 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, nolouch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Signed-off-by: husharp <[email protected]>
/test build |
@HuSharp: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest-required |
/test unit-test |
@HuSharp: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: husharp [email protected]<!--
Thank you for contributing to TiDB!
PR Title Format:
-->
What problem does this PR solve?
Issue Number: close #46770, ref tikv/pd#6556
Problem Summary:
When waiting for the goroutine to update, the expo function can be used to backoff to sleep when an error is encountered.
PR Summary
Add backoff mechanism
expo
function can be used to backoff to sleep when an error is encountered.Reproduce Step
enable fail point, like gRPC is throttling, cannot read from etcd.
curl -X PUT -d 'return(10)' http://tc-pd-1.tc-pd-peer.csn-simulator-big-cluster-vd62g.svc:2379/pd/api/v1/fail/github.com/tikv/pd/pkg/etcdutil/SlowEtcdKVGet
simulate pd lost leader
curl -X PUT -d 'return("2346857576170797299")' http://tc-pd-1.tc-pd-peer.csn-simulator-big-cluster-vd62g.svc:2379/pd/api/v1/fail/github.com/tikv/pd/server/exitCampaignLeader
Reproduce Result
Grpc request
GetMember
keeps high:TiKV side show
PR Effect
The Grpc
GetMember
call was reduced from 3.2k to 170, which is relative to the TiDB numbers and client requests for triaging checkLeader.For 20 * tidb 3 * PD 50 * TiKV
170 = (50 * 3 / 3 / 3[TiKV side] + 20 * 2 [TiDB side]) * 3[PD Num]
And more tests are necessary to ensure that no further issues arise.
What is changed and how it works?
Check List
test by pd
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.