-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gomod: update pdclient to support backoff mechanism for memberLoop (#46769) #46955
gomod: update pdclient to support backoff mechanism for memberLoop (#46769) #46955
Conversation
cc @HuSharp |
Signed-off-by: husharp <[email protected]>
bfdf20a
to
ab9eb16
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-7.1 #46955 +/- ##
================================================
Coverage ? 73.4658%
================================================
Files ? 1203
Lines ? 376756
Branches ? 0
================================================
Hits ? 276787
Misses ? 82315
Partials ? 17654 |
@@ -95,7 +95,7 @@ require ( | |||
github.com/tdakkota/asciicheck v0.2.0 | |||
github.com/tiancaiamao/appdash v0.0.0-20181126055449-889f96f722a2 | |||
github.com/tikv/client-go/v2 v2.0.8-0.20230713054852-a3875bcbc94f | |||
github.com/tikv/pd/client v0.0.0-20230519121736-d15a686a670e | |||
github.com/tikv/pd/client v0.0.0-20230905092614-113cdedbebb6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CabinfeverB: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CabinfeverB, nolouch, rleungx, xhebox The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #46769
Signed-off-by: husharp [email protected]<!--
Thank you for contributing to TiDB!
PR Title Format:
-->
What problem does this PR solve?
Issue Number: close #46770, ref tikv/pd#6556
Problem Summary:
When waiting for the goroutine to update, the expo function can be used to backoff to sleep when an error is encountered.
PR Summary
Add backoff mechanism
expo
function can be used to backoff to sleep when an error is encountered.Reproduce Step
enable fail point, like gRPC is throttling, cannot read from etcd.
curl -X PUT -d 'return(10)' http://tc-pd-1.tc-pd-peer.csn-simulator-big-cluster-vd62g.svc:2379/pd/api/v1/fail/github.com/tikv/pd/pkg/etcdutil/SlowEtcdKVGet
simulate pd lost leader
curl -X PUT -d 'return("2346857576170797299")' http://tc-pd-1.tc-pd-peer.csn-simulator-big-cluster-vd62g.svc:2379/pd/api/v1/fail/github.com/tikv/pd/server/exitCampaignLeader
Reproduce Result
Grpc request
GetMember
keeps high:TiKV side show
PR Effect
The Grpc
GetMember
call was reduced from 3.2k to 170, which is relative to the TiDB numbers and client requests for triaging checkLeader.For 20 * tidb 3 * PD 50 * TiKV
170 = (50 * 3 / 3 / 3[TiKV side] + 20 * 2 [TiDB side]) * 3[PD Num]
And more tests are necessary to ensure that no further issues arise.
What is changed and how it works?
Check List
test by pd
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.