-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: fix the issue about simplify outer join to inner join | tidb-test=pr/2313 #51750
planner: fix the issue about simplify outer join to inner join | tidb-test=pr/2313 #51750
Conversation
814a62f
to
f629178
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51750 +/- ##
=================================================
- Coverage 70.7663% 55.2908% -15.4756%
=================================================
Files 1475 1582 +107
Lines 437315 612221 +174906
=================================================
+ Hits 309472 338502 +29030
- Misses 108511 250780 +142269
- Partials 19332 22939 +3607
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/hold to avoid that tidb side is merged but tidb-test is not. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elsa0520, time-and-fate The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/unhold |
/merge |
@winoros: We have migrated to builtin Please use
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
/run-cherry-picker release-7.1 |
/run-cherry-picker release-7.5 |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
/cherry-pick release-6.5-20230625-v6.5.3 |
@elsa0520: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: ti-chi-bot <[email protected]>
What problem does this PR solve?
Issue Number: close #51560
Problem Summary:
The original codes will push the predicates that are not related to that child.
What changed and how does it work?
Don't do the recursively. Let the predicate-push-down to do the recursively.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.