Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix the issue about simplify outer join to inner join | tidb-test=pr/2313 #51750

Merged
merged 1 commit into from
Mar 16, 2024

Conversation

winoros
Copy link
Member

@winoros winoros commented Mar 13, 2024

What problem does this PR solve?

Issue Number: close #51560

Problem Summary:

The original codes will push the predicates that are not related to that child.

What changed and how does it work?

Don't do the recursively. Let the predicate-push-down to do the recursively.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 13, 2024
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Merging #51750 (f629178) into master (47a990e) will decrease coverage by 15.4756%.
Report is 49 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #51750         +/-   ##
=================================================
- Coverage   70.7663%   55.2908%   -15.4756%     
=================================================
  Files          1475       1582        +107     
  Lines        437315     612221     +174906     
=================================================
+ Hits         309472     338502      +29030     
- Misses       108511     250780     +142269     
- Partials      19332      22939       +3607     
Flag Coverage Δ
integration 37.7489% <ø> (?)
unit 70.4928% <ø> (-0.0948%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.5643% <ø> (+5.6225%) ⬆️

@winoros winoros changed the title planner: fix the issue about simplify outer join to inner join planner: fix the issue about simplify outer join to inner join | tidb-test=pr/2313 Mar 14, 2024
@winoros
Copy link
Member Author

winoros commented Mar 14, 2024

/retest

Copy link
Contributor

@elsa0520 elsa0520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 14, 2024
@winoros
Copy link
Member Author

winoros commented Mar 14, 2024

/hold to avoid that tidb side is merged but tidb-test is not.

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 14, 2024
Copy link

ti-chi-bot bot commented Mar 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elsa0520, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [elsa0520,time-and-fate]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 14, 2024
Copy link

ti-chi-bot bot commented Mar 14, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-14 14:25:16.967345974 +0000 UTC m=+954743.989592363: ☑️ agreed by elsa0520.
  • 2024-03-14 16:28:57.334955956 +0000 UTC m=+962164.357202343: ☑️ agreed by time-and-fate.

@winoros
Copy link
Member Author

winoros commented Mar 16, 2024

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 16, 2024
@winoros
Copy link
Member Author

winoros commented Mar 16, 2024

/merge

Copy link

ti-chi-bot bot commented Mar 16, 2024

@winoros: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit e158c21 into pingcap:master Mar 16, 2024
22 of 23 checks passed
@winoros winoros deleted the correct-outer-join-eliminate branch March 16, 2024 11:25
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Mar 25, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Mar 25, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #52057.

@winoros
Copy link
Member Author

winoros commented Mar 25, 2024

/run-cherry-picker release-7.1

@winoros
Copy link
Member Author

winoros commented Mar 25, 2024

/run-cherry-picker release-7.5

@winoros winoros added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Mar 25, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #52078.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #52079.

@elsa0520
Copy link
Contributor

elsa0520 commented May 8, 2024

/cherry-pick release-6.5-20230625-v6.5.3

@ti-chi-bot
Copy link
Member

@elsa0520: new pull request created to branch release-6.5-20230625-v6.5.3: #53099.

In response to this:

/cherry-pick release-6.5-20230625-v6.5.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In clause with null causes incorrect results
4 participants