Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix the issue about simplify outer join to inner join (#51750) | tidb-test=pr/2323 #53099

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #51750

What problem does this PR solve?

Issue Number: close #51560

Problem Summary:

The original codes will push the predicates that are not related to that child.

What changed and how does it work?

Don't do the recursively. Let the predicate-push-down to do the recursively.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5-20230625-v6.5.3 labels May 8, 2024
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 8, 2024
@elsa0520 elsa0520 changed the title planner: fix the issue about simplify outer join to inner join | tidb-test=pr/2313 (#51750) planner: fix the issue about simplify outer join to inner join | tidb-test=pr/2316 (#51750) May 8, 2024
@elsa0520
Copy link
Contributor

elsa0520 commented May 8, 2024

/test mysql-test

Copy link

tiprow bot commented May 8, 2024

@elsa0520: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@wuhuizuo
Copy link
Contributor

wuhuizuo commented May 8, 2024

/retitle planner: fix the issue about simplify outer join to inner join (#51750)

@ti-chi-bot ti-chi-bot bot changed the title planner: fix the issue about simplify outer join to inner join | tidb-test=pr/2316 (#51750) planner: fix the issue about simplify outer join to inner join (#51750) May 8, 2024
@wuhuizuo
Copy link
Contributor

wuhuizuo commented May 8, 2024

/retest

@elsa0520 elsa0520 changed the title planner: fix the issue about simplify outer join to inner join (#51750) planner: fix the issue about simplify outer join to inner join (#51750) | tidb-test=5372c633b9771f5c4326d527d02eac2a144d1d90 May 8, 2024
@elsa0520
Copy link
Contributor

elsa0520 commented May 8, 2024

/test mysql-test

Copy link

tiprow bot commented May 8, 2024

@elsa0520: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@wuhuizuo
Copy link
Contributor

wuhuizuo commented May 8, 2024

/retitle planner: fix the issue about simplify outer join to inner join (#51750) | tidb-test=pr/2266

@ti-chi-bot ti-chi-bot bot changed the title planner: fix the issue about simplify outer join to inner join (#51750) | tidb-test=5372c633b9771f5c4326d527d02eac2a144d1d90 planner: fix the issue about simplify outer join to inner join (#51750) | tidb-test=pr/2266 May 8, 2024
@wuhuizuo
Copy link
Contributor

wuhuizuo commented May 8, 2024

/retest

@wuhuizuo
Copy link
Contributor

wuhuizuo commented May 8, 2024

/retitle planner: fix the issue about simplify outer join to inner join (#51750) | tidb-test=pull/2266

@ti-chi-bot ti-chi-bot bot changed the title planner: fix the issue about simplify outer join to inner join (#51750) | tidb-test=pr/2266 planner: fix the issue about simplify outer join to inner join (#51750) | tidb-test=pull/2266 May 8, 2024
@wuhuizuo
Copy link
Contributor

wuhuizuo commented May 8, 2024

/retest

@elsa0520 elsa0520 changed the title planner: fix the issue about simplify outer join to inner join (#51750) | tidb-test=pull/2266 planner: fix the issue about simplify outer join to inner join (#51750) | tidb-test=pull/2323 May 8, 2024
@elsa0520
Copy link
Contributor

elsa0520 commented May 8, 2024

/test mysql-test

Copy link

tiprow bot commented May 8, 2024

@elsa0520: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@wuhuizuo
Copy link
Contributor

wuhuizuo commented May 8, 2024

/retitle planner: fix the issue about simplify outer join to inner join (#51750) | tidb-test=pr/2323

@ti-chi-bot ti-chi-bot bot changed the title planner: fix the issue about simplify outer join to inner join (#51750) | tidb-test=pull/2323 planner: fix the issue about simplify outer join to inner join (#51750) | tidb-test=pr/2323 May 8, 2024
@wuhuizuo
Copy link
Contributor

wuhuizuo commented May 8, 2024

/retest

@wuhuizuo
Copy link
Contributor

wuhuizuo commented May 8, 2024

/retest

@elsa0520
Copy link
Contributor

elsa0520 commented May 8, 2024

/test mysql-test

Copy link

tiprow bot commented May 8, 2024

@elsa0520: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release-6.5-20230625-v6.5.3@0e4da39). Click here to learn what that means.

Additional details and impacted files
@@                       Coverage Diff                        @@
##             release-6.5-20230625-v6.5.3     #53099   +/-   ##
================================================================
  Coverage                               ?   73.5421%           
================================================================
  Files                                  ?       1080           
  Lines                                  ?     347280           
  Branches                               ?          0           
================================================================
  Hits                                   ?     255397           
  Misses                                 ?      75513           
  Partials                               ?      16370           

Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can delete the irrelevant changed tests. Only keep the related one.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels May 8, 2024
Copy link
Contributor

@elsa0520 elsa0520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented May 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elsa0520, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 8, 2024
Copy link

ti-chi-bot bot commented May 8, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-08 11:37:28.180664671 +0000 UTC m=+1048401.937800245: ☑️ agreed by hawkingrei.
  • 2024-05-08 11:38:32.92330512 +0000 UTC m=+1048466.680440693: ☑️ agreed by elsa0520.

@ti-chi-bot ti-chi-bot bot merged commit 0695f1e into pingcap:release-6.5-20230625-v6.5.3 May 8, 2024
9 of 10 checks passed
@wuhuizuo wuhuizuo deleted the cherry-pick-51750-to-release-6.5-20230625-v6.5.3 branch May 9, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-6.5-20230625-v6.5.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants