Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: add simple serializing scheduler #51866

Merged
merged 8 commits into from
Mar 25, 2024

Conversation

AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Mar 18, 2024

What problem does this PR solve?

Issue Number: ref #51664

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 18, 2024
Copy link

tiprow bot commented Mar 18, 2024

Hi @AilinKid. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

.
Signed-off-by: AilinKid <[email protected]>
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Merging #51866 (757aa8f) into master (af76c2f) will decrease coverage by 15.8686%.
Report is 75 commits behind head on master.
The diff coverage is 44.8979%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #51866         +/-   ##
=================================================
- Coverage   70.7202%   54.8517%   -15.8686%     
=================================================
  Files          1477       1597        +120     
  Lines        438443     622500     +184057     
=================================================
+ Hits         310068     341452      +31384     
- Misses       108950     257387     +148437     
- Partials      19425      23661       +4236     
Flag Coverage Δ
integration 36.5433% <0.0000%> (?)
unit 70.4113% <44.8979%> (-0.1073%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 50.3747% <ø> (+4.4999%) ⬆️

.
Signed-off-by: AilinKid <[email protected]>

// TaskSchedulerContext is defined for scheduling logic calling, also facilitate interface-oriented coding and testing.
type TaskSchedulerContext interface {
getStack() *TaskStack
Copy link
Member

@winoros winoros Mar 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this method to export the stack? Just a method popTask is enough?

Copy link
Contributor Author

@AilinKid AilinKid Mar 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not enough, TaskSchedulerContext is just a wrapper of Stack, the scheduler should be responsible for how tasks are taken out and how it runs (operate on stack elements)

@winoros
Copy link
Member

winoros commented Mar 18, 2024

You should use ref #xxx in the pr description instead of close #xxx(

@winoros
Copy link
Member

winoros commented Mar 18, 2024

I think we don't need to export the TaskStack to other packages now that there's a TaskSchedulerContext to be exported?

@AilinKid
Copy link
Contributor Author

I think we don't need to export the TaskStack to other packages now that there's a TaskSchedulerContext to be exported?

make sense, changed, currently, we only exported the Stack interface.

Signed-off-by: AilinKid <[email protected]>
.
Signed-off-by: AilinKid <[email protected]>
@AilinKid
Copy link
Contributor Author

/test unit-test

Copy link

tiprow bot commented Mar 25, 2024

@AilinKid: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AilinKid
Copy link
Contributor Author

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Mar 25, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 25, 2024
Signed-off-by: AilinKid <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 25, 2024
Copy link

ti-chi-bot bot commented Mar 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Mar 25, 2024
@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 25, 2024
Copy link

ti-chi-bot bot commented Mar 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-25 09:51:23.821663931 +0000 UTC m=+1888710.843910319: ☑️ agreed by winoros.
  • 2024-03-25 10:12:36.929123675 +0000 UTC m=+1889983.951370057: ☑️ agreed by hawkingrei.

@ti-chi-bot ti-chi-bot bot merged commit a66a80e into pingcap:master Mar 25, 2024
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants