-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: add simple serializing scheduler #51866
Conversation
Signed-off-by: AilinKid <[email protected]>
Hi @AilinKid. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: AilinKid <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51866 +/- ##
=================================================
- Coverage 70.7202% 54.8517% -15.8686%
=================================================
Files 1477 1597 +120
Lines 438443 622500 +184057
=================================================
+ Hits 310068 341452 +31384
- Misses 108950 257387 +148437
- Partials 19425 23661 +4236
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: AilinKid <[email protected]>
pkg/planner/memo/task_scheduler.go
Outdated
|
||
// TaskSchedulerContext is defined for scheduling logic calling, also facilitate interface-oriented coding and testing. | ||
type TaskSchedulerContext interface { | ||
getStack() *TaskStack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this method to export the stack? Just a method popTask
is enough?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not enough, TaskSchedulerContext is just a wrapper of Stack, the scheduler should be responsible for how tasks are taken out and how it runs (operate on stack elements)
You should use |
I think we don't need to export the |
Signed-off-by: AilinKid <[email protected]>
Signed-off-by: AilinKid <[email protected]>
make sense, changed, currently, we only exported the Stack interface. |
Signed-off-by: AilinKid <[email protected]>
Signed-off-by: AilinKid <[email protected]>
/test unit-test |
@AilinKid: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Signed-off-by: AilinKid <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: ref #51664
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.