-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: add simple serializing scheduler #51866
Merged
Merged
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
1dea993
add simple serializing scheduler
AilinKid 87c1842
.
AilinKid 9722a6c
.
AilinKid 8b62cae
add benchmark
AilinKid 521488a
don't export the stack implementation
AilinKid fde1bd1
linter
AilinKid ec226a0
.
AilinKid 757aa8f
make stack unexported
AilinKid File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
// Copyright 2024 PingCAP, Inc. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
package memo | ||
|
||
var _ TaskScheduler = &SimpleTaskScheduler{} | ||
|
||
// TaskScheduler is a scheduling interface defined for serializing(single thread)/concurrent(multi thread) running. | ||
type TaskScheduler interface { | ||
ExecuteTasks() | ||
} | ||
|
||
// SimpleTaskScheduler is defined for serializing scheduling of memo tasks. | ||
type SimpleTaskScheduler struct { | ||
Err error | ||
SchedulerCtx TaskSchedulerContext | ||
} | ||
|
||
// ExecuteTasks implements the interface of TaskScheduler. | ||
func (s *SimpleTaskScheduler) ExecuteTasks() { | ||
stack := s.SchedulerCtx.getStack() | ||
defer func() { | ||
// when step output of the scheduler, if the stack is empty, clean and release it. | ||
if !stack.Empty() { | ||
stack.Destroy() | ||
} | ||
}() | ||
for !stack.Empty() { | ||
// when use customized stack to drive the tasks, the call-chain state is dived in the stack. | ||
task := stack.Pop() | ||
if err := task.execute(); err != nil { | ||
s.Err = err | ||
return | ||
} | ||
} | ||
} | ||
|
||
// TaskSchedulerContext is defined for scheduling logic calling, also facilitate interface-oriented coding and testing. | ||
type TaskSchedulerContext interface { | ||
getStack() *TaskStack | ||
pushTask(task Task) | ||
winoros marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,70 @@ | ||
// Copyright 2024 PingCAP, Inc. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
package memo | ||
|
||
import ( | ||
"errors" | ||
"strconv" | ||
"testing" | ||
|
||
"github.com/stretchr/testify/require" | ||
) | ||
|
||
// TestSchedulerContext is defined to test scheduling logic here. | ||
type TestSchedulerContext struct { | ||
ts *TaskStack | ||
} | ||
|
||
func (t *TestSchedulerContext) getStack() *TaskStack { | ||
return t.ts | ||
} | ||
|
||
func (t *TestSchedulerContext) pushTask(task Task) { | ||
t.ts.Push(task) | ||
} | ||
|
||
// TestSchedulerContext is defined to mock special error state in specified task. | ||
type TestTaskImpl2 struct { | ||
a int64 | ||
} | ||
|
||
func (t *TestTaskImpl2) execute() error { | ||
// mock error at special task | ||
if t.a == 2 { | ||
return errors.New("mock error at task id = 2") | ||
} | ||
return nil | ||
} | ||
|
||
func (t *TestTaskImpl2) desc() string { | ||
return strconv.Itoa(int(t.a)) | ||
} | ||
|
||
func TestSimpleTaskScheduler(t *testing.T) { | ||
testSchedulerContext := &TestSchedulerContext{ | ||
newTaskStack(), | ||
} | ||
testScheduler := &SimpleTaskScheduler{ | ||
SchedulerCtx: testSchedulerContext, | ||
} | ||
testScheduler.SchedulerCtx.pushTask(&TestTaskImpl2{a: 1}) | ||
testScheduler.SchedulerCtx.pushTask(&TestTaskImpl2{a: 2}) | ||
testScheduler.SchedulerCtx.pushTask(&TestTaskImpl2{a: 3}) | ||
|
||
var testTaskScheduler TaskScheduler = testScheduler | ||
testTaskScheduler.ExecuteTasks() | ||
require.NotNil(t, testScheduler.Err) | ||
require.Equal(t, testScheduler.Err.Error(), "mock error at task id = 2") | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this method to export the stack? Just a method
popTask
is enough?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not enough, TaskSchedulerContext is just a wrapper of Stack, the scheduler should be responsible for how tasks are taken out and how it runs (operate on stack elements)