Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore: use a limited workpool #51872

Merged
merged 3 commits into from
Mar 26, 2024
Merged

Conversation

3pointer
Copy link
Contributor

@3pointer 3pointer commented Mar 19, 2024

What problem does this PR solve?

Issue Number: ref #50701 close #51621

Problem Summary:
Currently eg.Go will generate too many goroutines if ingest too slow. then it will block goroutine release. eventually consume too many memory or even OOM.

What changed and how does it work?

This PR tried to give a high limitation of total download goroutines. which consider the balance of restore speed and memory usage.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Copy link

ti-chi-bot bot commented Mar 19, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 19, 2024
Copy link

tiprow bot commented Mar 19, 2024

Hi @3pointer. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked labels Mar 21, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 21, 2024
@3pointer 3pointer marked this pull request as ready for review March 26, 2024 06:44
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 26, 2024
Copy link

ti-chi-bot bot commented Mar 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leavrth, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 26, 2024
Copy link

ti-chi-bot bot commented Mar 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-21 09:40:54.378377562 +0000 UTC m=+1542481.400623950: ☑️ agreed by Leavrth.
  • 2024-03-26 06:48:21.538411729 +0000 UTC m=+1964128.560658113: ☑️ agreed by YuJuncen.

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Merging #51872 (0861bd5) into master (5a2b8e8) will decrease coverage by 15.6204%.
Report is 83 commits behind head on master.
The diff coverage is 30.7692%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #51872         +/-   ##
=================================================
- Coverage   70.7104%   55.0900%   -15.6204%     
=================================================
  Files          1477       1597        +120     
  Lines        438429     623940     +185511     
=================================================
+ Hits         310015     343729      +33714     
- Misses       108992     256366     +147374     
- Partials      19422      23845       +4423     
Flag Coverage Δ
integration 36.6562% <30.7692%> (?)
unit 70.4306% <23.0769%> (-0.0814%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 50.1127% <30.7692%> (+4.2533%) ⬆️

@Leavrth
Copy link
Contributor

Leavrth commented Mar 26, 2024

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2024
@Leavrth
Copy link
Contributor

Leavrth commented Mar 26, 2024

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2024
@Leavrth
Copy link
Contributor

Leavrth commented Mar 26, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Mar 26, 2024
@Leavrth
Copy link
Contributor

Leavrth commented Mar 26, 2024

/retest

@BornChanger
Copy link
Contributor

/type cherry-pick-for-release-8.0

@BornChanger
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit b6dd179 into pingcap:master Mar 26, 2024
35 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.0: #52110.

ti-chi-bot bot pushed a commit that referenced this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-8.0 ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

br node (8c27g) OOM when restore a big table of 150TB
5 participants