Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore: use a limited workpool (#51872) #52110

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #51872

What problem does this PR solve?

Issue Number: ref #50701 close #51621

Problem Summary:
Currently eg.Go will generate too many goroutines if ingest too slow. then it will block goroutine release. eventually consume too many memory or even OOM.

What changed and how does it work?

This PR tried to give a high limitation of total download goroutines. which consider the balance of restore speed and memory usage.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.0 labels Mar 26, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 26, 2024
13 tasks
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 26, 2024
Copy link

ti-chi-bot bot commented Mar 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, Leavrth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 26, 2024
Copy link

ti-chi-bot bot commented Mar 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-26 09:49:41.856088777 +0000 UTC m=+1975008.878335165: ☑️ agreed by Leavrth.
  • 2024-03-26 09:50:06.855910223 +0000 UTC m=+1975033.878156606: ☑️ agreed by BornChanger.

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-8.0@99e63f1). Click here to learn what that means.
The diff coverage is 15.3846%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.0     #52110   +/-   ##
================================================
  Coverage               ?   70.6552%           
================================================
  Files                  ?       1477           
  Lines                  ?     438355           
  Branches               ?          0           
================================================
  Hits                   ?     309721           
  Misses                 ?     109176           
  Partials               ?      19458           
Flag Coverage Δ
unit 70.4468% <15.3846%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 45.8072% <0.0000%> (?)

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Mar 26, 2024
@ti-chi-bot ti-chi-bot bot merged commit d4ef3b2 into pingcap:release-8.0 Mar 26, 2024
26 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants