-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restore: use a limited workpool (#51872) #52110
restore: use a limited workpool (#51872) #52110
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger, Leavrth The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-8.0 #52110 +/- ##
================================================
Coverage ? 70.6552%
================================================
Files ? 1477
Lines ? 438355
Branches ? 0
================================================
Hits ? 309721
Misses ? 109176
Partials ? 19458
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This is an automated cherry-pick of #51872
What problem does this PR solve?
Issue Number: ref #50701 close #51621
Problem Summary:
Currently eg.Go will generate too many goroutines if ingest too slow. then it will block goroutine release. eventually consume too many memory or even OOM.
What changed and how does it work?
This PR tried to give a high limitation of total download goroutines. which consider the balance of restore speed and memory usage.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.