Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: set proper default flen of decimal(0) columns #54028

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

tangenta
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #53779

Problem Summary:

See #53779.

What changed and how does it work?

Handle Decimal(0) properly in preprocessing.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 14, 2024
Copy link

tiprow bot commented Jun 14, 2024

Hi @tangenta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tangenta tangenta changed the title ddl: fset proper default flen of decimal(0) columns ddl: set proper default flen of decimal(0) columns Jun 14, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 14, 2024
Copy link

ti-chi-bot bot commented Jun 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 14, 2024
Copy link

ti-chi-bot bot commented Jun 14, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-14 07:42:43.840971606 +0000 UTC m=+709717.894283531: ☑️ agreed by wjhuang2016.
  • 2024-06-14 07:48:52.222478964 +0000 UTC m=+710086.275790886: ☑️ agreed by hawkingrei.

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.7692%. Comparing base (b96a775) to head (1493036).
Report is 1038 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #54028         +/-   ##
=================================================
- Coverage   72.5347%   55.7692%   -16.7655%     
=================================================
  Files          1508       1628        +120     
  Lines        432015     602660     +170645     
=================================================
+ Hits         313361     336099      +22738     
- Misses        99268     243377     +144109     
- Partials      19386      23184       +3798     
Flag Coverage Δ
integration 37.2117% <55.5555%> (?)
unit 71.4174% <88.8888%> (-0.1102%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8522% <ø> (-0.0945%) ⬇️
parser ∅ <ø> (∅)
br 50.6163% <ø> (+8.3535%) ⬆️

@ti-chi-bot ti-chi-bot bot merged commit 518b512 into pingcap:master Jun 14, 2024
22 checks passed
@GMHDBJD GMHDBJD added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Jul 15, 2024
@GMHDBJD
Copy link
Contributor

GMHDBJD commented Jul 15, 2024

/run-cherrypick

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #54619.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jul 15, 2024
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label Jul 30, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #55068.

@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Aug 27, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #55695.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Aug 27, 2024
@ti-chi-bot ti-chi-bot bot removed the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Aug 27, 2024
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Oct 28, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Oct 28, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #56893.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid column type decimal(0,0) can be created unexpectedly
5 participants