-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: set proper default flen of decimal(0) columns (#54028) #54619
ddl: set proper default flen of decimal(0) columns (#54028) #54619
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: GMHDBJD, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #54619 +/- ##
================================================
Coverage ? 72.1567%
================================================
Files ? 1412
Lines ? 412689
Branches ? 0
================================================
Hits ? 297783
Misses ? 95050
Partials ? 19856
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This is an automated cherry-pick of #54028
What problem does this PR solve?
Issue Number: close #53779
Problem Summary:
See #53779.
What changed and how does it work?
Handle
Decimal(0)
properly in preprocessing.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.