-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: replace local ingest impl with backfill operators #54149
Conversation
Hi @tangenta. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #54149 +/- ##
=================================================
- Coverage 72.8341% 56.0493% -16.7849%
=================================================
Files 1519 1645 +126
Lines 435334 609579 +174245
=================================================
+ Hits 317072 341665 +24593
- Misses 98694 244643 +145949
- Partials 19568 23271 +3703
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest lgtm
pkg/sessionctx/variable/tidb_vars.go
Outdated
@@ -1379,7 +1379,7 @@ const ( | |||
DefTiDBSessionPlanCacheSize = 100 | |||
DefTiDBEnablePrepPlanCacheMemoryMonitor = true | |||
DefTiDBPrepPlanCacheMemoryGuardRatio = 0.1 | |||
DefTiDBEnableDistTask = true | |||
DefTiDBEnableDistTask = false // TODO: remove this after CI passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to resolve this
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: D3Hunter, lance6716, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request could not be created: failed to create pull request against pingcap/tidb#release-8.1 from head ti-chi-bot:cherry-pick-54149-to-release-8.1: the GitHub API request returns a 403 error: {"message":"You have exceeded a secondary rate limit and have been temporarily blocked from content creation. Please retry your request again later. If you reach out to GitHub Support for help, please include the request ID 8AAC:12E1BA:5C7620:AFE9E6:66A3541F and timestamp 2024-07-26 07:45:36 UTC.","documentation_url":"https://docs.github.com/rest/overview/rate-limits-for-the-rest-api#about-secondary-rate-limits","status":"403"} |
Signed-off-by: ti-chi-bot <[email protected]>
/cherry-pick release-8.1 |
@MimeLyc: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: ti-chi-bot <[email protected]>
What problem does this PR solve?
Issue Number: close #53909, close #53910
Problem Summary: See #53909 (comment)
What changed and how does it work?
Before fixing the context usage, I prefer to unify local ingest and distributed ingest implementation, remove the old
ingestBackfillScheduler
.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.