-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl code refactor/optimize #54436
Labels
type/enhancement
The issue or PR belongs to an enhancement.
Comments
13 tasks
This was referenced Jul 10, 2024
13 tasks
13 tasks
13 tasks
13 tasks
13 tasks
13 tasks
13 tasks
12 tasks
13 tasks
13 tasks
12 tasks
13 tasks
13 tasks
EricZequan
pushed a commit
to EricZequan/tidb
that referenced
this issue
Sep 29, 2024
13 tasks
13 tasks
13 tasks
13 tasks
This was referenced Oct 16, 2024
13 tasks
This was referenced Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Enhancement
We have listed a lot of items that we want to refactor, to make the structure more clear and code easier to maintain and extend, and some optimize tasks to make general DDL run faster. And in the last 8.2 sprint, we optimized for general DDL, and done some refactor for job scheduling and have left some TODOs during the refactor, #53246.
In 8.3 sprint, we have the same goal as in 8.2 and we also want to enhance testibility of DDL component, by decoupling different part of DDL(TODO), and replacing ddl.Hook with simplier failpoint.
Decouple components of DDL
Currently, ddl/ddlCtx is quite large and has a lot of responsibility, including:
Tasks
ddl
#54858separate local job execution out: we have integrate fast-create into general DDL, see ddl: integrate fast create table into normal general DDL workflow #55025ddl
#54858OnJobUpdated
callback with failpoint #55091OnJobRunAfter
callback with failpoint #55120copReqSenderPool
and related structures #55302The text was updated successfully, but these errors were encountered: