-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parser: Support VECTOR type #54246
parser: Support VECTOR type #54246
Conversation
Signed-off-by: Wish <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #54246 +/- ##
=================================================
- Coverage 72.9282% 54.9661% -17.9621%
=================================================
Files 1523 1642 +119
Lines 435564 607228 +171664
=================================================
+ Hits 317649 333770 +16121
- Misses 98420 250958 +152538
- Partials 19495 22500 +3005
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Wish <[email protected]>
Hi @hawkingrei @breezewish are we going to support vector in the next release(v8.3.0)? |
@bb7133 Hi, the VECTOR type support is planned this Q, but we have not estimated work time for it yet. |
/approve |
/merge |
@breezewish: We have migrated to builtin 👉 Please use
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/approve |
[LGTM Timeline notifier]Timeline:
|
@breezewish: We have migrated to builtin 👉 Please use
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
1 similar comment
@breezewish: We have migrated to builtin 👉 Please use
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crazycs520, easonn7, hawkingrei, tangenta, XuHuaiyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/merge |
@breezewish: We have migrated to builtin 👉 Please use
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
@breezewish Looks like somehow
|
@dveeden Thanks for pointing out! A fix for the keyword (and a fix to prevent future mistakes) are now proposed in #54371 |
What problem does this PR solve?
Issue Number: ref #54245
Problem Summary:
What changed and how does it work?
Support parsing the VECTOR type. However we does not support execute it.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.