-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makefile: add a lint for parser's keywords #54827
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @HuSharp. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: husharp <[email protected]>
ac327bb
to
f7c8a80
Compare
@breezewish @tangenta @glorv PTAL, thx! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #54827 +/- ##
================================================
- Coverage 72.7769% 72.7438% -0.0332%
================================================
Files 1557 1557
Lines 437912 437912
================================================
- Hits 318699 318554 -145
- Misses 99582 99663 +81
- Partials 19631 19695 +64
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Duplicate with #54371? |
Let's close this pr. |
What problem does this PR solve?
#54246 has not updated keywords, maybe we need a lint to check parser/keywords
Issue Number: Ref #54245
Problem Summary:
What changed and how does it work?
When meet error
After fixing error
Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.