Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl/ingest: move backend ctx out of checkpoint manager #54292

Merged
merged 7 commits into from
Jul 12, 2024

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Jun 28, 2024

What problem does this PR solve?

Issue Number: ref #42164

Problem Summary:

What changed and how does it work?

  • Move backend ctx out of checkpoint manager and remove FlushCtrl.
  • Remove incomplete and unstable test TestAddIndexIngestRecoverPartition.
  • Add a failure test during ingest.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 28, 2024
Copy link

tiprow bot commented Jun 28, 2024

Hi @tangenta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 97.36842% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.5670%. Comparing base (ae02500) to head (ea3e570).
Report is 14 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #54292         +/-   ##
=================================================
- Coverage   74.7881%   56.5670%   -18.2211%     
=================================================
  Files          1548       1670        +122     
  Lines        362079     617117     +255038     
=================================================
+ Hits         270792     349085      +78293     
- Misses        71710     244597     +172887     
- Partials      19577      23435       +3858     
Flag Coverage Δ
integration 37.3599% <78.9473%> (?)
unit 71.9041% <81.5789%> (-1.8101%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (-2.2339%) ⬇️
parser ∅ <ø> (∅)
br 53.2514% <ø> (+5.5452%) ⬆️

@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 10, 2024
@tangenta tangenta changed the title tests: refine TestAddIndexIngestRecoverPartition ddl/ingest: move backend ctx out of checkpoint manager Jul 10, 2024
@tangenta
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Jul 10, 2024

@tangenta: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

})
}

func ExecuteBlocks(t *testing.T, fns ...func()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain the purpose of this function? Seems it runs fns in different processes. But fns are not executed until the previous one exited, can we run them one-by-one in one process?

Copy link
Contributor Author

@tangenta tangenta Jul 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we run them one-by-one in one process?

No. I want to simulate the case like kill -9 with os.Exit(0), and see if the checkpoint manager can handle this correctly. By running them in different processes, we can exit at any point of the routine.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 10, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 11, 2024
Copy link

ti-chi-bot bot commented Jul 11, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-10 12:28:13.965938649 +0000 UTC m=+446991.201172757: ☑️ agreed by lance6716.
  • 2024-07-11 02:41:40.303580648 +0000 UTC m=+498197.538814760: ☑️ agreed by D3Hunter.

@D3Hunter D3Hunter mentioned this pull request Jul 11, 2024
54 tasks
@tangenta
Copy link
Contributor Author

/approve

Copy link

ti-chi-bot bot commented Jul 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, lance6716, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 11, 2024
@tangenta
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Jul 11, 2024

@tangenta: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tangenta
Copy link
Contributor Author

Blocked by #54543

@tangenta
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Jul 12, 2024

@tangenta: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit ceb20b7 into pingcap:master Jul 12, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants