ddl: query since min job id #54693
ddl: query since min job id #54693
Conversation
ti-chi-bot
bot
added
release-note-none
|
Hi @D3Hunter. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #54693 +/- ##
=================================================
- Coverage 72.7411% 56.1579% -16.5833%
=================================================
Files 1551 1680 +129
Lines 437183 617904 +180721
=================================================
+ Hits 318012 347002 +28990
- Misses 99532 247276 +147744
- Partials 19639 23626 +3987
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pkg/ddl/ddl_worker.go
Outdated
| @@ -411,16 +411,17 @@ func (d *ddl) addBatchDDLJobs(jobWs []*JobWrapper) error { | |||
| return nil | |||
| } | |||
|
|
|||
| ctx := kv.WithInternalSourceType(context.Background(), kv.InternalTxnDDL) | |||
There was a problem hiding this comment.
| ctx := kv.WithInternalSourceType(context.Background(), kv.InternalTxnDDL) | |
| ctx := kv.WithInternalSourceType(d.ctx, kv.InternalTxnDDL) |
| schCtx: ctx, | ||
| cancel: cancelFunc, | ||
| runningJobs: newRunningJobs(), | ||
| sysTblMgr: sysTblMgr, |
There was a problem hiding this comment.
can we use ddl.sysTblMgr?
There was a problem hiding this comment.
it's just a wrapper around session pool, both lgtm
|
/retest |
|
@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance6716, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
approved
lgtm
and removed
needs-1-more-lgtm
What problem does this PR solve?
Issue Number: ref #54436
Problem Summary:
What changed and how does it work?
second pr mentioned in #54547, now we pessimistic lock global id, and generate global id and insert job in one txn, so we can make sure when job of ID A which is the minimum in a txn submitted, no jobs of ID < A can be inserted, so it's safe to query since min job id
selectvery slow on an empty table fromdelete from xx#52905. by query since min job id, tikv can directly seek to the starting KV and skip all those that have deleted but not compacted without scanningCheck List
Tests
same case as in #54581, takes 11m24, and there is very little speed degradation now
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.