Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] Bench ART(Adaptive Radix Tree) as memdb #54828

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

you06
Copy link
Contributor

@you06 you06 commented Jul 23, 2024

What problem does this PR solve?

Issue Number: ref #55287

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Copy link

ti-chi-bot bot commented Jul 23, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from you06, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 23, 2024
Copy link

tiprow bot commented Jul 23, 2024

Hi @you06. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 23, 2024
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.4679%. Comparing base (1acbbec) to head (e13271e).
Report is 90 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #54828        +/-   ##
================================================
+ Coverage   73.4107%   75.4679%   +2.0572%     
================================================
  Files          1600       1601         +1     
  Lines        443769     447545      +3776     
================================================
+ Hits         325774     337753     +11979     
+ Misses        98039      89293      -8746     
- Partials      19956      20499       +543     
Flag Coverage Δ
integration 49.0844% <ø> (?)
unit 72.4529% <ø> (-0.0200%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (-0.0089%) ⬇️
parser ∅ <ø> (∅)
br 52.8499% <ø> (+6.9838%) ⬆️

@you06
Copy link
Contributor Author

you06 commented Jul 24, 2024

/test mysql-test

Copy link

tiprow bot commented Jul 24, 2024

@you06: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 25, 2024
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 25, 2024
@you06 you06 changed the title [DMR] Bench ART(Adaptive Radix Tree) as memdb [DNM] Bench ART(Adaptive Radix Tree) as memdb Jul 26, 2024
@you06
Copy link
Contributor Author

you06 commented Jul 29, 2024

/retest

Copy link

tiprow bot commented Jul 29, 2024

@you06: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@you06
Copy link
Contributor Author

you06 commented Jul 29, 2024

/release

@you06
Copy link
Contributor Author

you06 commented Aug 1, 2024

/test pull-integration-ddl-test

Copy link

tiprow bot commented Aug 1, 2024

@you06: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-integration-ddl-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/needs-linked-issue labels Aug 8, 2024
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 23, 2024
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 28, 2024
Signed-off-by: you06 <[email protected]>

bazel

Signed-off-by: you06 <[email protected]>

support snapshot (reverse) iter

Signed-off-by: you06 <[email protected]>

fix long prefix search

Signed-off-by: you06 <[email protected]>

fix bugs...

Signed-off-by: you06 <[email protected]>

fix error when setting empty value

Signed-off-by: you06 <[email protected]>

fix bug when mismatchIdx > maxPrefixLen

Signed-off-by: you06 <[email protected]>

fix seek bug in art

Signed-off-by: you06 <[email protected]>

fix seek bug

Signed-off-by: you06 <[email protected]>

fix art's len and size

Signed-off-by: you06 <[email protected]>

fix dirty and len

Signed-off-by: you06 <[email protected]>

fix iterator checking prefix

Signed-off-by: you06 <[email protected]>

support checkpoint & fix iter seek

Signed-off-by: you06 <[email protected]>

support value size limit

Signed-off-by: you06 <[email protected]>

add random test & fix bug

Signed-off-by: you06 <[email protected]>

add random staging test

Signed-off-by: you06 <[email protected]>

add random flag iter test

Signed-off-by: you06 <[email protected]>

fix iter

Signed-off-by: you06 <[email protected]>

set value for

Signed-off-by: you06 <[email protected]>

set delete flag for cleanup node

Signed-off-by: you06 <[email protected]>

fix flag

Signed-off-by: you06 <[email protected]>

bazel

Signed-off-by: you06 <[email protected]>

accelarate init iterator

Signed-off-by: you06 <[email protected]>

update client-go

Signed-off-by: you06 <[email protected]>

opt minimum

Signed-off-by: you06 <[email protected]>

remove unnecessary check & use unsafe.Sizeof

Signed-off-by: you06 <[email protected]>

remove unnecessary check in minimum

Signed-off-by: you06 <[email protected]>

remove unused present for n4 and n16 & enlarge in-node prefix

Signed-off-by: you06 <[email protected]>

fast search for n256

Signed-off-by: you06 <[email protected]>

test refactored memdb

Signed-off-by: you06 <[email protected]>

fix SnapshotIterReverse

Signed-off-by: you06 <[email protected]>

test memdb cache fix

Signed-off-by: you06 <[email protected]>

test 0 handle

Signed-off-by: you06 <[email protected]>
Signed-off-by: you06 <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 24, 2024
Signed-off-by: you06 <[email protected]>
Copy link

ti-chi-bot bot commented Sep 24, 2024

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/invalid-title label, please follow title format, for example pkg [, pkg2, pkg3]: what is changed or *: what is changed.

📖 For more info, you can check the "Contribute Code" section in the development guide.


Notice: To remove the do-not-merge/needs-tests-checked label, please finished the tests then check the finished items in description.

For example:

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

📖 For more info, you can check the "Contribute Code" section in the development guide.

@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 24, 2024
Copy link

ti-chi-bot bot commented Sep 24, 2024

@you06: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/build e13271e link true /test build

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 28, 2024
Copy link

ti-chi-bot bot commented Sep 28, 2024

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/invalid-title do-not-merge/needs-tests-checked needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant