planner: derive index filters for mv index paths #54877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
release-note-none
|
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #54877 +/- ##
================================================
+ Coverage 72.9336% 74.7540% +1.8204%
================================================
Files 1558 1564 +6
Lines 438456 447217 +8761
================================================
+ Hits 319782 334313 +14531
+ Misses 99064 92605 -6459
- Partials 19610 20299 +689
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ti-chi-bot
bot
added
release-note
|
/retest |
AilinKid
reviewed
Jul 26, 2024
AilinKid
approved these changes
Jul 26, 2024
| @@ -1081,3 +1081,127 @@ IndexMerge 0.05 root type: union | |||
| └─Selection(Probe) 0.05 cop[tikv] eq(planner__core__indexmerge_path.t.a, 1) | |||
| └─TableRowIDScan 49.94 cop[tikv] table:t keep order:false, stats:pseudo | |||
| SET @@tidb_opt_fix_control = default; | |||
| drop table if exists t, t1; | |||
There was a problem hiding this comment.
the logic code change makes sense to me, by the way, is there any test case that needs to be modified?
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
Co-authored-by: Arenatlx <[email protected]>
winoros
approved these changes
Jul 26, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
morgo
added a commit
to morgo/tidb
that referenced
this pull request
Jul 28, 2024
* upstream/master: (93 commits) disjoinset: add generic impl (pingcap#54917) planner: derive index filters for mv index paths (pingcap#54877) br: cli refactor backup error handling logic (pingcap#54697) expression: fix infinity loop in `timestampadd` (pingcap#54916) planner: import more expand test. (pingcap#54962) planner: use code-gen to generate CloneForPlanCache method for some operators (pingcap#54957) test: fix flaky test TestFailSchemaSyncer (pingcap#54958) planner: move logical show into logicalop pkg. (pingcap#54928) privilege: Remove TestAbnormalMySQLTable (pingcap#54925) resource_control: support unlimited keyword when setting the resource group (pingcap#54704) ddl: fix a data race on localRowCntListener Written() (pingcap#54484) lightning: fix SET SESSION on connection pool (pingcap#54927) planner: move logical mem-table to logicalop pkg. (pingcap#54903) table: Add `CachedTableSupport` and `TemporaryTableSupport` for `MutateContext` (pingcap#54900) executor: fix index_hash_join hang when context canceled (pingcap#54855) statistics: add metrics for unneeded analyze table (pingcap#54822) *: refine pipelined dml benchmarks (pingcap#54844) ddl: assign table IDs for jobs submitted to queue (pingcap#54880) *: avoid using Tables field of model.DBInfo, use API instead (pingcap#52302) planner: remove useless check (pingcap#54907) ...
|
/cherry-pick release-8.1 |
|
@time-and-fate: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
ti-chi-bot
pushed a commit
to ti-chi-bot/tidb
that referenced
this pull request
Jul 29, 2024
Signed-off-by: ti-chi-bot <[email protected]>
13 tasks
hawkingrei
pushed a commit
to hawkingrei/tidb
that referenced
this pull request
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #54876
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.