Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

privilege: Remove TestAbnormalMySQLTable #54925

Merged
merged 1 commit into from
Jul 26, 2024
Merged

privilege: Remove TestAbnormalMySQLTable #54925

merged 1 commit into from
Jul 26, 2024

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Jul 26, 2024

What problem does this PR solve?

Issue Number: close #54924

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 26, 2024
@tiprow tiprow
Copy link

tiprow bot commented Jul 26, 2024

Hi @dveeden. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dveeden
Copy link
Contributor Author

dveeden commented Jul 26, 2024

/check-issue-triage-complete

@dveeden
Copy link
Contributor Author

dveeden commented Jul 26, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Jul 26, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 26, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.6946%. Comparing base (2ee8c99) to head (a82179a).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #54925        +/-   ##
================================================
+ Coverage   72.7654%   74.6946%   +1.9292%     
================================================
  Files          1559       1559                
  Lines        438446     438484        +38     
================================================
+ Hits         319037     327524      +8487     
+ Misses        99738      90812      -8926     
- Partials      19671      20148       +477
Flag Coverage Δ
integration 49.3898% <ø> (?)
unit 71.6908% <ø> (-0.0673%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 52.5556% <ø> (+6.6512%) ⬆️

@dveeden dveeden requested a review from bb7133 July 26, 2024 07:21
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CbcWestwolf, tiancaiamao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CbcWestwolf,tiancaiamao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 26, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-26 07:00:51.525579538 +0000 UTC m=+1201273.516521007: ☑️ agreed by CbcWestwolf.
  • 2024-07-26 07:57:56.617586684 +0000 UTC m=+1204698.608528155: ☑️ agreed by tiancaiamao.

@ti-chi-bot ti-chi-bot bot merged commit da7d83f into pingcap:master Jul 26, 2024
23 checks passed
@hawkingrei hawkingrei mentioned this pull request Jul 26, 2024
Closed
morgo added a commit to morgo/tidb that referenced this pull request Jul 28, 2024
@morgo
Merge remote-tracking branch 'upstream/master' into add-default-literal
4424521 
* upstream/master: (93 commits)
  disjoinset: add generic impl (pingcap#54917)
  planner: derive index filters for mv index paths (pingcap#54877)
  br: cli refactor backup error handling logic (pingcap#54697)
  expression: fix infinity loop in `timestampadd` (pingcap#54916)
  planner: import more expand test. (pingcap#54962)
  planner: use code-gen to generate CloneForPlanCache method for some operators (pingcap#54957)
  test: fix flaky test TestFailSchemaSyncer (pingcap#54958)
  planner: move logical show into logicalop pkg. (pingcap#54928)
  privilege: Remove TestAbnormalMySQLTable (pingcap#54925)
  resource_control: support unlimited keyword when setting the resource group (pingcap#54704)
  ddl: fix a data race on localRowCntListener Written() (pingcap#54484)
  lightning: fix SET SESSION on connection pool (pingcap#54927)
  planner: move logical mem-table to logicalop pkg. (pingcap#54903)
  table: Add `CachedTableSupport` and `TemporaryTableSupport` for `MutateContext` (pingcap#54900)
  executor: fix index_hash_join hang when context canceled (pingcap#54855)
  statistics: add metrics for unneeded analyze table (pingcap#54822)
  *: refine pipelined dml benchmarks (pingcap#54844)
  ddl: assign table IDs for jobs submitted to queue (pingcap#54880)
  *: avoid using Tables field of model.DBInfo, use API instead (pingcap#52302)
  planner: remove useless check (pingcap#54907)
  ...
hawkingrei pushed a commit to hawkingrei/tidb that referenced this pull request Aug 1, 2024
@dveeden @hawkingrei
privilege: Remove TestAbnormalMySQLTable (pingcap#54925)
a42b256 
close pingcap#54924
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CbcWestwolf CbcWestwolf CbcWestwolf approved these changes

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@xhebox xhebox Awaiting requested review from xhebox

@tisonkun tisonkun Awaiting requested review from tisonkun

@bb7133 bb7133 Awaiting requested review from bb7133

Assignees
No one assigned
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TestAbnormalMySQLTable has multiple issues.
3 participants
@dveeden @tiancaiamao @CbcWestwolf