store/copr: partly revert pr/35975, do it correctly this time

[tiancaiamao]

What problem does this PR solve?

Issue Number: close #54969

Problem Summary:

What changed and how does it work?

#55155 try to revert pr/35975 but not clean, coupling with #41500 and bring bugs. PartitionNum is 1 even on non-partitioned table.

Do it correctly in this PR.
The new behaviour now:

• The 'select ... where ... order by ...' query will not reduce distsql concurrency to 2 (change)
• The simple 'select ... limit N' query, when N < 10000 , distsql concurrency is set to 1 (keep the behavior no change)
  • The same 'select ... limit N' query, on partitioned table, distsql concurrency is set to partition number (keep the behavior no change)

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @tiancaiamao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[tiancaiamao]

Known issue #55190
Will not be fixed in this PR.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.8170%. Comparing base (07c35e8) to head (4e9dfc4).
Report is 277 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #55196        +/-   ##
================================================
+ Coverage   74.7289%   74.8170%   +0.0880%     
================================================
  Files          1570       1570                
  Lines        364634     439916     +75282     
================================================
+ Hits         272487     329132     +56645     
- Misses        72419      90561     +18142     
- Partials      19728      20223       +495     

Flag	Coverage Δ
integration	49.4801% <82.1428%> (?)
unit	71.7868% <100.0000%> (-1.8238%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9567% <ø> (-2.2327%)	⬇️
parser	∅ <ø> (∅)
br	52.4987% <ø> (+4.8242%)	⬆️

[windtalker]

LGTM

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-08-05 10:41:08.140581289 +0000 UTC m=+262198.007680400: ☑️ agreed by Defined2014.
• 2024-08-05 11:57:54.128300519 +0000 UTC m=+266803.995399608: ☑️ agreed by windtalker.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Defined2014,windtalker]
• pkg/distsql/OWNERS [windtalker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hawkingrei]

/ok-to-test

[winoros]

Is 6.5 affected by this problem?

[tiancaiamao]

Is 6.5 affected by this problem?

Yes

[tiancaiamao]

/test unit-test

#55207

[ti-chi-bot]

@tiancaiamao: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test build
• /test check-dev
• /test check-dev2
• /test mysql-test
• /test pull-br-integration-test
• /test pull-integration-ddl-test
• /test pull-lightning-integration-test
• /test pull-mysql-client-test
• /test unit-test

The following commands are available to trigger optional jobs:

• /test canary-notify-when-compatibility-sections-changed
• /test pingcap/tidb/canary_ghpr_unit_test
• /test pull-common-test
• /test pull-e2e-test
• /test pull-integration-common-test
• /test pull-integration-copr-test
• /test pull-integration-jdbc-test
• /test pull-integration-mysql-test
• /test pull-integration-nodejs-test
• /test pull-sqllogic-test
• /test pull-tiflash-test

Use /test all to run the following jobs that were automatically triggered:

• pingcap/tidb/ghpr_build
• pingcap/tidb/ghpr_check
• pingcap/tidb/ghpr_check2
• pingcap/tidb/ghpr_mysql_test
• pingcap/tidb/ghpr_unit_test
• pingcap/tidb/pull_integration_ddl_test
• pingcap/tidb/pull_mysql_client_test

In response to this:

/test unit-test

#55207

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tiprow]

@tiancaiamao: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test fast_test_tiprow
• /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test unit-test

#55207

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[tiancaiamao]

/test check-dev

[tiprow]

@tiancaiamao: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test fast_test_tiprow
• /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test check-dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.5: #55211.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-8.1: #55212.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-6.5: #55645.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.1: #56009.