-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
store/copr: partly revert pr/35975, do it correctly this time (#55196) #55211
store/copr: partly revert pr/35975, do it correctly this time (#55196) #55211
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #55211 +/- ##
================================================
Coverage ? 72.2517%
================================================
Files ? 1413
Lines ? 412797
Branches ? 0
================================================
Hits ? 298253
Misses ? 94795
Partials ? 19749
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, windtalker The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This is an automated cherry-pick of #55196
What problem does this PR solve?
Issue Number: close #54969
Problem Summary:
What changed and how does it work?
#55155 try to revert pr/35975 but not clean, coupling with #41500 and bring bugs. PartitionNum is 1 even on non-partitioned table.
Do it correctly in this PR.
The new behaviour now:
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.