-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: make tidb_enable_stats_owner controlling the stats owner #55592
config: make tidb_enable_stats_owner controlling the stats owner #55592
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #55592 +/- ##
=================================================
- Coverage 72.9147% 59.6105% -13.3043%
=================================================
Files 1605 1811 +206
Lines 446513 662426 +215913
=================================================
+ Hits 325574 394876 +69302
- Misses 100899 243017 +142118
- Partials 20040 24533 +4493
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
Signed-off-by: Weizhen Wang <[email protected]>
c960d44
to
4114295
Compare
please involve a PM review |
/retest |
PM have known it and agree with it. |
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
need to update PR title |
Signed-off-by: Weizhen Wang <[email protected]>
Co-authored-by: Yiding Cui <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
/retest |
2 similar comments
/retest |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Signed-off-by: Weizhen Wang <[email protected]>
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance6716, winoros, yudongusa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #55989
Problem Summary:
What changed and how does it work?
Check List
Tests
if disable this variable, you cannot find the auto-analyze stack in the profiler.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.