-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parser, ddl: support vector index at the parser #55698
parser, ddl: support vector index at the parser #55698
Conversation
Hi @zimulala. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/vector-index #55698 +/- ##
=============================================================
- Coverage 72.9771% 56.7601% -16.2170%
=============================================================
Files 1581 1705 +124
Lines 442336 614914 +172578
=============================================================
+ Hits 322804 349026 +26222
- Misses 99782 241978 +142196
- Partials 19750 23910 +4160
Flags with carried forward coverage won't be shown. Click here to find out more.
|
8063135
to
6ad9965
Compare
pkg/parser/keywords.go
Outdated
@@ -247,6 +247,7 @@ var Keywords = []KeywordsType{ | |||
{"VARCHAR", true, "reserved"}, | |||
{"VARCHARACTER", true, "reserved"}, | |||
{"VARYING", true, "reserved"}, | |||
{"VECTOR", true, "reserved"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Differ from MySQL, this is changed to revered keyword?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MySQL does not currently support vector keys: link.
Indexing-related keywords such as fulltext
and unique
are reserved, so this is also done here. In addition, it is a little complicated to process without a reserved word.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PM(@joey-yez ) comments that if it is used as the reserved keyword, there will be compatibility. So I will update it.
[LGTM Timeline notifier]Timeline:
|
/cc @yudongusa |
@wuhuizuo: GitHub didn't allow me to request PR reviews from the following users: yudongusa. Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@joey-yez: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test unit-test |
@zimulala: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
PTAL @yudongusa @easonn7 |
/test pull-br-integration-test |
@zimulala: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for DDL syntax. Please make sure test this thoroughly.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joey-yez, tangenta, tiancaiamao, yudongusa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #55694
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.