Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser, ddl: support vector index at the parser #55698

Merged

Conversation

zimulala
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #55694

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 27, 2024
Copy link

tiprow bot commented Aug 27, 2024

Hi @zimulala. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.7601%. Comparing base (44f100f) to head (4ef375d).
Report is 1 commits behind head on feature/vector-index.

Additional details and impacted files
@@                      Coverage Diff                      @@
##           feature/vector-index     #55698         +/-   ##
=============================================================
- Coverage               72.9771%   56.7601%   -16.2170%     
=============================================================
  Files                      1581       1705        +124     
  Lines                    442336     614914     +172578     
=============================================================
+ Hits                     322804     349026      +26222     
- Misses                    99782     241978     +142196     
- Partials                  19750      23910       +4160     
Flag Coverage Δ
integration 38.1984% <0.0000%> (?)
unit 71.8770% <100.0000%> (-0.1868%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 62.8187% <ø> (+17.5395%) ⬆️

@pingcap pingcap deleted a comment from ti-chi-bot bot Aug 27, 2024
@pingcap pingcap deleted a comment from ti-chi-bot bot Aug 27, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 28, 2024
@@ -247,6 +247,7 @@ var Keywords = []KeywordsType{
{"VARCHAR", true, "reserved"},
{"VARCHARACTER", true, "reserved"},
{"VARYING", true, "reserved"},
{"VECTOR", true, "reserved"},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Differ from MySQL, this is changed to revered keyword?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MySQL does not currently support vector keys: link.
Indexing-related keywords such as fulltext and unique are reserved, so this is also done here. In addition, it is a little complicated to process without a reserved word.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PM(@joey-yez ) comments that if it is used as the reserved keyword, there will be compatibility. So I will update it.

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 28, 2024
Copy link

ti-chi-bot bot commented Aug 28, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-28 02:48:29.529616568 +0000 UTC m=+924904.664066682: ☑️ agreed by tangenta.
  • 2024-08-28 03:23:56.319648268 +0000 UTC m=+927031.454098389: ☑️ agreed by tiancaiamao.

@wuhuizuo
Copy link
Contributor

/cc @yudongusa

Copy link

ti-chi-bot bot commented Aug 28, 2024

@wuhuizuo: GitHub didn't allow me to request PR reviews from the following users: yudongusa.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @yudongusa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zimulala zimulala requested a review from joey-yez August 28, 2024 06:15
Copy link

ti-chi-bot bot commented Aug 30, 2024

@joey-yez: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zimulala
Copy link
Contributor Author

/test unit-test

Copy link

tiprow bot commented Aug 30, 2024

@zimulala: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@zimulala
Copy link
Contributor Author

zimulala commented Sep 2, 2024

PTAL @yudongusa @easonn7

@zimulala
Copy link
Contributor Author

zimulala commented Sep 2, 2024

/test pull-br-integration-test

Copy link

tiprow bot commented Sep 2, 2024

@zimulala: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

@yudongusa yudongusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for DDL syntax. Please make sure test this thoroughly.

Copy link

ti-chi-bot bot commented Sep 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joey-yez, tangenta, tiancaiamao, yudongusa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 2, 2024
@ti-chi-bot ti-chi-bot bot merged commit 95b92f7 into pingcap:feature/vector-index Sep 2, 2024
21 checks passed
@zimulala zimulala deleted the zimuxia/vector-index-parser branch September 2, 2024 04:08
@zimulala zimulala mentioned this pull request Sep 29, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants