Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: support the vector index #56409

Merged
merged 13 commits into from
Sep 30, 2024
Merged

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Sep 29, 2024

What problem does this PR solve?

Issue Number: ref #55693

Problem Summary:
Merge https://github.com/pingcap/tidb/tree/feature/vector-index to the master branch.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Support the vector index

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. sig/planner SIG: Planner labels Sep 29, 2024
Copy link

tiprow bot commented Sep 29, 2024

Hi @zimulala. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pingcap pingcap deleted a comment from ti-chi-bot bot Sep 29, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 29, 2024
Copy link

codecov bot commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 73.43533% with 191 lines in your changes missing coverage. Please review.

Project coverage is 76.1781%. Comparing base (762a6f2) to head (1b2f01a).
Report is 3 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #56409        +/-   ##
================================================
+ Coverage   73.3948%   76.1781%   +2.7832%     
================================================
  Files          1623       1645        +22     
  Lines        447233     457093      +9860     
================================================
+ Hits         328246     348205     +19959     
+ Misses        98892      87328     -11564     
- Partials      20095      21560      +1465     
Flag Coverage Δ
integration 51.9507% <25.4335%> (?)
unit 72.5619% <71.6272%> (+0.0816%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 63.0613% <ø> (+17.5141%) ⬆️

pkg/parser/parser.y Outdated Show resolved Hide resolved
errors.toml Outdated Show resolved Hide resolved
pkg/ddl/executor.go Outdated Show resolved Hide resolved
pkg/parser/parser.y Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 29, 2024
@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 29, 2024
Copy link

ti-chi-bot bot commented Sep 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-29 09:09:57.767863894 +0000 UTC m=+173153.188076906: ☑️ agreed by wjhuang2016.
  • 2024-09-29 10:16:32.618809474 +0000 UTC m=+177148.039022486: ☑️ agreed by AilinKid.

@pingcap pingcap deleted a comment from ti-chi-bot bot Sep 29, 2024
@pingcap pingcap deleted a comment from tiprow bot Sep 29, 2024
pkg/ddl/create_table.go Outdated Show resolved Hide resolved
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@pingcap pingcap deleted a comment from ti-chi-bot bot Sep 30, 2024
Copy link

@yudongusa yudongusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Sep 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, tangenta, wjhuang2016, yudongusa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 30, 2024
@ti-chi-bot ti-chi-bot bot merged commit 6e8f27f into pingcap:master Sep 30, 2024
23 checks passed
@zimulala zimulala deleted the zimuxia/vec-idx branch September 30, 2024 08:00
@zimulala zimulala mentioned this pull request Sep 30, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants