Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: Provide TIFLASH_INDEXES table #55901

Merged
merged 4 commits into from
Sep 10, 2024
Merged

executor: Provide TIFLASH_INDEXES table #55901

merged 4 commits into from
Sep 10, 2024

Conversation

EricZequan
Copy link
Contributor

@EricZequan EricZequan commented Sep 6, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #54245

Problem Summary:

What changed and how does it work?

Pick part of https://github.com/tidbcloud/tidb-cse/pull/1030

  • supports providing TIFLASH_INDEXES table

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@EricZequan
Provide TiFlash sys tables and TIFLASH_INDEXES
310a819 
Signed-off-by: “EricZequan” <[email protected]>
@EricZequan
fix ut test
9d5a2bc 
Signed-off-by: “EricZequan” <[email protected]>
@ti-chi-bot ti-chi-bot bot added do-not-merge/invalid-title release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 6, 2024
@tiprow tiprow
Copy link

tiprow bot commented Sep 6, 2024

Hi @EricZequan. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@EricZequan EricZequan changed the title Clear vector index executor: Provide TIFLASH_INDEXES table Sep 6, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (feature/vector-index@95b92f7). Learn more about missing BASE report.

Additional details and impacted files 
@@                    Coverage Diff                    @@
##             feature/vector-index     #55901   +/-   ##
=========================================================
  Coverage                        ?   56.9143%           
=========================================================
  Files                           ?       1730           
  Lines                           ?     622854           
  Branches                        ?          0           
=========================================================
  Hits                            ?     354493           
  Misses                          ?     243860           
  Partials                        ?      24501
Flag Coverage Δ
integration 39.3487% <25.0000%> (?)
unit 71.8711% <50.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 62.7006% <0.0000%> (?)

@EricZequan
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Sep 6, 2024

@EricZequan: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@EricZequan
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Sep 6, 2024

@EricZequan: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@EricZequan
fix ut failed
5c8c865 
Signed-off-by: “EricZequan” <[email protected]>
@EricZequan
Copy link
Contributor Author

/cc @breezewish

@ti-chi-bot ti-chi-bot bot requested a review from breezewish September 6, 2024 10:11
@EricZequan
Copy link
Contributor Author

/cc @zimulala

@ti-chi-bot ti-chi-bot bot requested a review from zimulala September 6, 2024 10:14
zimulala
zimulala reviewed Sep 6, 2024
View reviewed changes
pkg/infoschema/tables.go Outdated
var tableTiFlashIndexesCols = []columnInfo{
{name: "TIDB_DATABASE", tp: mysql.TypeVarchar, size: 64},
{name: "TIDB_TABLE", tp: mysql.TypeVarchar, size: 64},
{name: "TABLE_ID", tp: mysql.TypeLonglong, size: 64},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

64->21 or update when I handle https://github.com/pingcap/tidb/issues/48323？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modified.

@EricZequan
fix comment
f7738b7 
Signed-off-by: “EricZequan” <[email protected]>
zimulala
zimulala approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 6, 2024
@breezewish
Copy link
Member

Partially duplicated with #55817?

@EricZequan
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Sep 9, 2024

@EricZequan: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@EricZequan
Copy link
Contributor Author

EricZequan commented Sep 9, 2024 •
edited
Loading

Partially duplicated with #55817?

image

#55817 not pick tiflash_indexex table， so I added it.

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 10, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 10, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-06 11:29:12.708040724 +0000 UTC m=+10222.448464664: ☑️ agreed by zimulala.
  • 2024-09-10 03:38:21.37057205 +0000 UTC m=+327571.110995992: ☑️ agreed by breezewish.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, breezewish, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 10, 2024
@ti-chi-bot ti-chi-bot bot merged commit 66dbc71 into pingcap:feature/vector-index Sep 10, 2024
22 checks passed
@zimulala zimulala mentioned this pull request Sep 29, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breezewish breezewish breezewish approved these changes

@zimulala zimulala zimulala approved these changes

@AilinKid AilinKid AilinKid approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EricZequan @breezewish @zimulala @AilinKid