Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: refactor the args for the DDL type of renametable #55959

Merged
merged 13 commits into from
Sep 18, 2024

Conversation

joccau
Copy link
Member

@joccau joccau commented Sep 9, 2024

What problem does this PR solve?

Issue Number: Ref #53930
Ref #54436

Problem Summary:

  • Refactor the args in ddl job for the type of renametable

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked do-not-merge/needs-linked-issue labels Sep 9, 2024
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 81.48148% with 15 lines in your changes missing coverage. Please review.

Project coverage is 56.6072%. Comparing base (26443da) to head (36c1356).
Report is 3 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #55959         +/-   ##
=================================================
- Coverage   72.9073%   56.6072%   -16.3002%     
=================================================
  Files          1610       1763        +153     
  Lines        447262     633407     +186145     
=================================================
+ Hits         326087     358554      +32467     
- Misses       101111     250120     +149009     
- Partials      20064      24733       +4669     
Flag Coverage Δ
integration 39.3100% <59.2592%> (?)
unit 72.0080% <81.4814%> (+0.0033%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 63.0457% <ø> (+17.2470%) ⬆️

pkg/meta/model/job_args.go Outdated Show resolved Hide resolved
pkg/ddl/ddl_test.go Outdated Show resolved Hide resolved
@D3Hunter
Copy link
Contributor

link this issue #53930

@joccau joccau force-pushed the rename-table-args branch 3 times, most recently from 1466c4d to 5ec0a39 Compare September 13, 2024 03:53
Signed-off-by: joccau <[email protected]>
@joccau joccau force-pushed the rename-table-args branch 2 times, most recently from 3fede3c to b361ab8 Compare September 13, 2024 08:54
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 13, 2024
@joccau
Copy link
Member Author

joccau commented Sep 16, 2024

/test pull-br-integration-test

Copy link

tiprow bot commented Sep 16, 2024

@joccau: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@joccau
Copy link
Member Author

joccau commented Sep 17, 2024

/test pull-br-integration-test

Copy link

tiprow bot commented Sep 17, 2024

@joccau: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: joccau <[email protected]>
@joccau
Copy link
Member Author

joccau commented Sep 17, 2024

/test unit-test

Copy link

tiprow bot commented Sep 17, 2024

@joccau: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

pkg/ddl/executor.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 18, 2024
Copy link
Contributor

@D3Hunter D3Hunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

pkg/ddl/executor.go Outdated Show resolved Hide resolved
pkg/ddl/executor.go Outdated Show resolved Hide resolved
pkg/ddl/job_scheduler.go Outdated Show resolved Hide resolved
pkg/ddl/table_test.go Outdated Show resolved Hide resolved
pkg/meta/model/job_args_test.go Outdated Show resolved Hide resolved
pkg/meta/model/job_args_test.go Outdated Show resolved Hide resolved
pkg/meta/model/job_args_test.go Outdated Show resolved Hide resolved
pkg/meta/model/job_args_test.go Outdated Show resolved Hide resolved
@joccau joccau changed the title ddl: refactor the args for the DDL type of renametable ddl: refactor the args for the DDL type of renametable[wip] Sep 18, 2024
Signed-off-by: joccau <[email protected]>
Copy link

ti-chi-bot bot commented Sep 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 18, 2024
Copy link

ti-chi-bot bot commented Sep 18, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-18 02:54:39.505669634 +0000 UTC m=+1016149.246093574: ☑️ agreed by lance6716.
  • 2024-09-18 06:01:22.390623998 +0000 UTC m=+1027352.131047962: ☑️ agreed by D3Hunter.

@D3Hunter D3Hunter changed the title ddl: refactor the args for the DDL type of renametable[wip] [wip]ddl: refactor the args for the DDL type of renametable Sep 18, 2024
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 18, 2024
@ti-chi-bot ti-chi-bot bot merged commit 8313bbc into pingcap:master Sep 18, 2024
25 checks passed
@joccau joccau changed the title [wip]ddl: refactor the args for the DDL type of renametable ddl: refactor the args for the DDL type of renametable Sep 18, 2024
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants