-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: refactor the args for the DDL type of renametable #55959
Conversation
Signed-off-by: joccau <[email protected]>
Signed-off-by: joccau <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #55959 +/- ##
=================================================
- Coverage 72.9073% 56.6072% -16.3002%
=================================================
Files 1610 1763 +153
Lines 447262 633407 +186145
=================================================
+ Hits 326087 358554 +32467
- Misses 101111 250120 +149009
- Partials 20064 24733 +4669
Flags with carried forward coverage won't be shown. Click here to find out more.
|
link this issue #53930 |
Signed-off-by: joccau <[email protected]>
7b619c8
to
266da27
Compare
Signed-off-by: joccau <[email protected]>
Signed-off-by: joccau <[email protected]>
1466c4d
to
5ec0a39
Compare
Signed-off-by: joccau <[email protected]>
3fede3c
to
b361ab8
Compare
Signed-off-by: joccau <[email protected]>
26ede03
to
5da35dc
Compare
/test pull-br-integration-test |
@joccau: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test pull-br-integration-test |
@joccau: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
e3bb6d1
to
5a61960
Compare
Signed-off-by: joccau <[email protected]>
5a61960
to
2aafaad
Compare
/test unit-test |
@joccau: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: joccau <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest lgtm
Signed-off-by: joccau <[email protected]>
a72216c
to
36c1356
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: D3Hunter, lance6716 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: Ref #53930
Ref #54436
Problem Summary:
renametable
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.