Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: args v2 for lock/unlock/repair table and recover table/schema #56194

Merged
merged 16 commits into from
Sep 25, 2024
Merged

ddl: args v2 for lock/unlock/repair table and recover table/schema #56194

merged 16 commits into from
Sep 25, 2024

Conversation

joechenrh
Copy link
Contributor

@joechenrh joechenrh commented Sep 20, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #53930

Problem Summary:

What changed and how does it work?

As title.

To resolve cycle import, meta.AutoIDGroup, ddl.RecoverInfo and ddl.RecoverSchemaInfo have been moved into model package.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 20, 2024
@tiprow tiprow
Copy link

tiprow bot commented Sep 20, 2024

Hi @joechenrh. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov Codecov
Copy link

codecov bot commented Sep 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 84.94624% with 28 lines in your changes missing coverage. Please review.

Project coverage is 76.1506%. Comparing base (bf455f5) to head (dca73d3).
Report is 11 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #56194        +/-   ##
================================================
+ Coverage   73.4156%   76.1506%   +2.7349%     
================================================
  Files          1605       1627        +22     
  Lines        445006     453324      +8318     
================================================
+ Hits         326704     345209     +18505     
+ Misses        98251      86657     -11594     
- Partials      20051      21458      +1407
Flag Coverage Δ
integration 51.8804% <24.7311%> (?)
unit 72.5610% <84.9462%> (+0.0532%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 63.0903% <ø> (+17.0593%) ⬆️

@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 23, 2024
@joechenrh joechenrh changed the title ddl: args v2 for lock/unlock repair table ddl: args v2 for lock/unlock repair table and recover table/schema Sep 23, 2024
@D3Hunter D3Hunter mentioned this pull request Sep 23, 2024
Open
54 tasks
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 24, 2024
@joechenrh joechenrh changed the title ddl: args v2 for lock/unlock repair table and recover table/schema ddl: args v2 for lock/unlock/repair table and recover table/schema Sep 24, 2024
@joechenrh
Copy link
Contributor Author

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Sep 24, 2024
@joechenrh
Copy link
Contributor Author

/retest

@joechenrh
Copy link
Contributor Author

/test all

D3Hunter
D3Hunter reviewed Sep 24, 2024
View reviewed changes
Copy link
Contributor

@D3Hunter D3Hunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

pkg/meta/model/job_args.go Outdated Show resolved Hide resolved
pkg/meta/model/job_args.go Outdated Show resolved Hide resolved
pkg/meta/model/job_args.go Outdated Show resolved Hide resolved
pkg/meta/model/job_args.go Outdated Show resolved Hide resolved
pkg/meta/model/job_args_test.go Outdated Show resolved Hide resolved
joccau
joccau reviewed Sep 24, 2024
View reviewed changes
pkg/ddl/schema_version.go
if err != nil {
return errors.Trace(err)
}
// Reserved recoverSchemaCheckFlag value for gc work judgment.
job.Args[checkFlagIndexInJobArgs] = recoverSchemaCheckFlag
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reserved recoverSchemaCheckFlag ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why it decode recoverSchemaCheckFlag and set it again here. I'll remove the comment here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might because it became a pointer after DecodeArgs

joccau
joccau reviewed Sep 24, 2024
View reviewed changes
Copy link
Member

@joccau joccau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 25, 2024
joccau
joccau approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@joccau joccau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, joccau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 25, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-25 02:29:56.990621771 +0000 UTC m=+1619466.731045712: ☑️ agreed by D3Hunter.
  • 2024-09-25 07:35:12.907030521 +0000 UTC m=+1637782.647454459: ☑️ agreed by joccau.

@joechenrh
Copy link
Contributor Author

/test all

@D3Hunter
Copy link
Contributor

/retest

1 similar comment
@D3Hunter
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit 75483d8 into pingcap:master Sep 25, 2024
25 checks passed
@joechenrh joechenrh deleted the addargs-locktable branch October 12, 2024 08:52
@D3Hunter D3Hunter mentioned this pull request Oct 14, 2024
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joccau joccau joccau approved these changes

@D3Hunter D3Hunter D3Hunter approved these changes

Assignees
No one assigned
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joechenrh @D3Hunter @joccau