-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: Stabilized TestRemovePartitioningAutoIDs test. #56436
ddl: Stabilized TestRemovePartitioningAutoIDs test. #56436
Conversation
Hi @mjonss. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #56436 +/- ##
================================================
+ Coverage 73.3650% 76.4452% +3.0802%
================================================
Files 1624 1648 +24
Lines 448069 459415 +11346
================================================
+ Hits 328726 351201 +22475
+ Misses 99206 86700 -12506
- Partials 20137 21514 +1377
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
@mjonss: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest |
@purelind: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[LGTM Timeline notifier]Timeline:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bb7133, lance6716, wjhuang2016 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
* origin/master: ddl: Stabilized TestRemovePartitioningAutoIDs test. (pingcap#56436) execdetails: Display vector search info in EXPLAIN ANALYZE (pingcap#56478) ddl: abstract decode job args v1 (pingcap#56420)
What problem does this PR solve?
Issue Number: close #54759
Problem Summary:
Unstable test
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.