Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: Stabilized TestRemovePartitioningAutoIDs test. #56436

Conversation

mjonss
Copy link
Contributor

@mjonss mjonss commented Oct 2, 2024

What problem does this PR solve?

Issue Number: close #54759

Problem Summary:
Unstable test

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 2, 2024
Copy link

tiprow bot commented Oct 2, 2024

Hi @mjonss. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.4452%. Comparing base (74034d4) to head (a2b12e9).
Report is 20 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #56436        +/-   ##
================================================
+ Coverage   73.3650%   76.4452%   +3.0802%     
================================================
  Files          1624       1648        +24     
  Lines        448069     459415     +11346     
================================================
+ Hits         328726     351201     +22475     
+ Misses        99206      86700     -12506     
- Partials      20137      21514      +1377     
Flag Coverage Δ
integration 52.4413% <ø> (?)
unit 72.8835% <ø> (+0.4199%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 63.5181% <ø> (+18.0050%) ⬆️

@mjonss
Copy link
Contributor Author

mjonss commented Oct 2, 2024

/retest

Copy link

tiprow bot commented Oct 2, 2024

@mjonss: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@purelind
Copy link
Contributor

purelind commented Oct 2, 2024

/retest

Copy link

tiprow bot commented Oct 2, 2024

@purelind: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 3, 2024
@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 8, 2024
Copy link

ti-chi-bot bot commented Oct 8, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-03 22:53:47.073583253 +0000 UTC m=+568182.493796265: ☑️ agreed by bb7133.
  • 2024-10-08 12:35:58.146590875 +0000 UTC m=+963113.566803887: ☑️ agreed by wjhuang2016.

Copy link

ti-chi-bot bot commented Oct 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, lance6716, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Oct 8, 2024
@ti-chi-bot ti-chi-bot bot merged commit df821b9 into pingcap:master Oct 8, 2024
25 checks passed
@mjonss mjonss deleted the stabilize-TestRemovePartitioningAutoIDs-test branch October 8, 2024 19:59
breezewish added a commit to winoros/tidb that referenced this pull request Oct 9, 2024
* origin/master:
  ddl: Stabilized TestRemovePartitioningAutoIDs test. (pingcap#56436)
  execdetails: Display vector search info in EXPLAIN ANALYZE (pingcap#56478)
  ddl: abstract decode job args v1 (pingcap#56420)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flaky test TestRemovePartitioningAutoIDs
6 participants