Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

execdetails: Display vector search info in EXPLAIN ANALYZE #56478

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

breezewish
Copy link
Member

@breezewish breezewish commented Oct 8, 2024

What problem does this PR solve?

Issue Number: ref #54245

Problem Summary:

Cherry-pick: https://github.com/tidbcloud/tidb-cse/pull/913 https://github.com/tidbcloud/tidb-cse/pull/925

What changed and how does it work?

Add a couple of metrics for benchmarking with vector scan.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked do-not-merge/needs-linked-issue labels Oct 8, 2024
Copy link

ti-chi-bot bot commented Oct 8, 2024

@JaySon-Huang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.3231%. Comparing base (55fadff) to head (4bad1a0).
Report is 3 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #56478        +/-   ##
================================================
+ Coverage   73.2713%   75.3231%   +2.0517%     
================================================
  Files          1626       1626                
  Lines        448916     449202       +286     
================================================
+ Hits         328927     338353      +9426     
+ Misses        99830      90222      -9608     
- Partials      20159      20627       +468     
Flag Coverage Δ
integration 48.8373% <65.2173%> (?)
unit 72.4620% <100.0000%> (+0.0146%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 52.3492% <ø> (+6.8778%) ⬆️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 8, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 8, 2024
Copy link

ti-chi-bot bot commented Oct 8, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-08 12:46:41.682661906 +0000 UTC m=+963757.102874918: ☑️ agreed by winoros.
  • 2024-10-08 13:45:26.630496592 +0000 UTC m=+967282.050709795: ☑️ agreed by lance6716.

Copy link

ti-chi-bot bot commented Oct 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongyunyan, JaySon-Huang, lance6716, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hongyunyan,lance6716,winoros]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit c3a85be into master Oct 8, 2024
21 of 23 checks passed
@ti-chi-bot ti-chi-bot bot deleted the wenxuan/vector/explain_details branch October 8, 2024 15:10
breezewish added a commit to winoros/tidb that referenced this pull request Oct 9, 2024
* origin/master:
  ddl: Stabilized TestRemovePartitioningAutoIDs test. (pingcap#56436)
  execdetails: Display vector search info in EXPLAIN ANALYZE (pingcap#56478)
  ddl: abstract decode job args v1 (pingcap#56420)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants