ddl: move insert job to table to job submitter #56542
Conversation
ti-chi-bot
bot
added
release-note-none
|
Hi @D3Hunter. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #56542 +/- ##
================================================
+ Coverage 73.4138% 76.0120% +2.5981%
================================================
Files 1626 1648 +22
Lines 449042 457012 +7970
================================================
+ Hits 329659 347384 +17725
+ Misses 99188 87969 -11219
- Partials 20195 21659 +1464
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
| @@ -764,7 +666,7 @@ func updateDDLJob2Table( | |||
| if err != nil { | |||
| return err | |||
| } | |||
| sql := fmt.Sprintf(updateDDLJobSQL, util.WrapKey2String(b), job.ID) | |||
| sql := fmt.Sprintf("update mysql.tidb_ddl_job set job_meta = %s where job_id = %d", util.WrapKey2String(b), job.ID) | |||
There was a problem hiding this comment.
I think original updataDDLJobSQL variable would be better?
There was a problem hiding this comment.
the reason I inline it is nearly all other place use string literal directly, and it's only used once
I do agree to define it as const if it's or will be used multiple times, but seems we won't
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: GMHDBJD, lance6716 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
What problem does this PR solve?
Issue Number: ref #54436
Problem Summary:
What changed and how does it work?
as title, they are only used there
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.