Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: change some param for cdc #56624

Merged
merged 1 commit into from
Oct 14, 2024
Merged

ddl: change some param for cdc #56624

merged 1 commit into from
Oct 14, 2024

Conversation

D3Hunter
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #54436

Problem Summary:

What changed and how does it work?

CDC depends on GetLastNHistoryDDLJobs where a meta reader should be used

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • only change param type to reduce the scope of APIs can be called

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 14, 2024
Copy link

tiprow bot commented Oct 14, 2024

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.9752%. Comparing base (69f8a7b) to head (5e200df).
Report is 2 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #56624         +/-   ##
=================================================
- Coverage   73.3331%   56.9752%   -16.3579%     
=================================================
  Files          1629       1778        +149     
  Lines        449951     636787     +186836     
=================================================
+ Hits         329963     362811      +32848     
- Misses        99746     248942     +149196     
- Partials      20242      25034       +4792     
Flag Coverage Δ
integration 39.2045% <0.0000%> (?)
unit 72.4758% <100.0000%> (+0.0040%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 63.2002% <ø> (+17.6273%) ⬆️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 14, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 14, 2024
Copy link

ti-chi-bot bot commented Oct 14, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-14 03:31:32.117088557 +0000 UTC m=+241889.265998386: ☑️ agreed by tangenta.
  • 2024-10-14 03:32:46.835709769 +0000 UTC m=+241963.984619596: ☑️ agreed by lance6716.

Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Oct 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, CbcWestwolf, lance6716, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 94b2ac0 into pingcap:master Oct 14, 2024
26 checks passed
@D3Hunter D3Hunter deleted the for-cdc branch October 14, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants