Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl_notifier: get complete table info after unmarshal SchemaChangeEvent #56796

Closed

Conversation

fzzf678
Copy link
Contributor

@fzzf678 fzzf678 commented Oct 23, 2024

What problem does this PR solve?

Issue Number: ref #55722

Problem Summary:

What changed and how does it work?

DBID int64 `json:"-"`

The DBID is ignored when marshaling TableInfo, so the DBID is always 0 after we unmarshal the SchemaChangeEvent, the follow-up event process logic may be failed by this. So we get the complete table info by table id before process event.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Oct 23, 2024
Copy link

ti-chi-bot bot commented Oct 23, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gmhdbjd for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 23, 2024
Copy link

tiprow bot commented Oct 23, 2024

Hi @fzzf678. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 68.42105% with 6 lines in your changes missing coverage. Please review.

Project coverage is 57.0588%. Comparing base (ba5823b) to head (0f70377).
Report is 5 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #56796         +/-   ##
=================================================
- Coverage   73.3727%   57.0588%   -16.3140%     
=================================================
  Files          1635       1785        +150     
  Lines        452770     639629     +186859     
=================================================
+ Hits         332210     364965      +32755     
- Misses       100208     249571     +149363     
- Partials      20352      25093       +4741     
Flag Coverage Δ
integration 39.3214% <68.4210%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 63.1157% <ø> (+17.0926%) ⬆️

Copy link

ti-chi-bot bot commented Oct 23, 2024

@fzzf678: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-unit-test-ddlv1 0f70377 link true /test pull-unit-test-ddlv1
idc-jenkins-ci-tidb/unit-test 0f70377 link true /test unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fzzf678 fzzf678 closed this Oct 23, 2024
@fzzf678
Copy link
Contributor Author

fzzf678 commented Oct 23, 2024

replace by #56803

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant