-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl_notifier: get complete table info after unmarshal SchemaChangeEvent #56796
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @fzzf678. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #56796 +/- ##
=================================================
- Coverage 73.3727% 57.0588% -16.3140%
=================================================
Files 1635 1785 +150
Lines 452770 639629 +186859
=================================================
+ Hits 332210 364965 +32755
- Misses 100208 249571 +149363
- Partials 20352 25093 +4741
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@fzzf678: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
replace by #56803 |
What problem does this PR solve?
Issue Number: ref #55722
Problem Summary:
What changed and how does it work?
tidb/pkg/meta/model/table.go
Line 196 in ba5823b
The
DBID
is ignored when marshaling TableInfo, so theDBID
is always0
after we unmarshal theSchemaChangeEvent
, the follow-up event process logic may be failed by this. So we get the complete table info by table id before process event.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.