Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infoschema: improve usability of SchemaByTable #56803

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

lance6716
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #50959

Problem Summary:

What changed and how does it work?

In development, we store the TableInfo in a system table. After unmarshal, we use SchemaByTable to find its database. However SchemaByTable can only be used with TableInfo that are not go through de(serialization).

So change SchemaByTable to support all TableInfo

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 23, 2024
Copy link

tiprow bot commented Oct 23, 2024

Hi @lance6716. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 23, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 23, 2024
Copy link

ti-chi-bot bot commented Oct 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-23 08:06:19.281400416 +0000 UTC m=+424779.978191021: ☑️ agreed by tiancaiamao.
  • 2024-10-23 08:09:07.290068582 +0000 UTC m=+424947.986859209: ☑️ agreed by fzzf678.

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.1315%. Comparing base (48c57ce) to head (d925547).
Report is 4 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #56803         +/-   ##
=================================================
- Coverage   73.3104%   57.1315%   -16.1789%     
=================================================
  Files          1636       1786        +150     
  Lines        453230     640131     +186901     
=================================================
+ Hits         332265     365717      +33452     
- Misses       100614     249336     +148722     
- Partials      20351      25078       +4727     
Flag Coverage Δ
integration 39.3823% <37.5000%> (?)
unit 72.6393% <100.0000%> (+0.1138%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 63.1729% <ø> (+17.1403%) ⬆️

@lance6716
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Oct 23, 2024

@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Oct 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fzzf678, GMHDBJD, tiancaiamao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 23, 2024
@ti-chi-bot ti-chi-bot bot merged commit 5cbe855 into pingcap:master Oct 23, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants