-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statistics: make sure PQ can analyze all indexes with stats version 1 #57258
statistics: make sure PQ can analyze all indexes with stats version 1 #57258
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #57258 +/- ##
================================================
+ Coverage 72.9810% 73.7087% +0.7276%
================================================
Files 1660 1690 +30
Lines 458645 466664 +8019
================================================
+ Hits 334724 343972 +9248
+ Misses 103364 101490 -1874
- Partials 20557 21202 +645
Flags with carried forward coverage won't be shown. Click here to find out more.
|
6f2622e
to
176f178
Compare
Signed-off-by: Rustin170506 <[email protected]>
176f178
to
cfafd02
Compare
Signed-off-by: Rustin170506 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pkg/statistics/handle/autoanalyze/priorityqueue/non_partitioned_table_analysis_job.go
Outdated
Show resolved
Hide resolved
/hold |
Signed-off-by: Rustin170506 <[email protected]>
/unhold |
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elsa0520, qw4990 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ti-chi-bot Wake up |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #57257
Problem Summary:
What changed and how does it work?
After switching to the new PQ, we only have one chance to analyze newly added indexes. For example, if two indexes are created in a very short period and the analyze version 1 is used, we need to analyze these indexes separately.
However, with the current implementation, we only analyze one index at a time, which means the second index will be missed.
In this PR, I’ve checked the analyze version to ensure proper handling. The lower versions don’t have this issue because we can analyze the second index after rebuilding the entire priority queue.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.