Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: make sure PQ can analyze all indexes with stats version 1 (#57258) #57286

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #57258

What problem does this PR solve?

Issue Number: close #57257

Problem Summary:

What changed and how does it work?

After switching to the new PQ, we only have one chance to analyze newly added indexes. For example, if two indexes are created in a very short period and the analyze version 1 is used, we need to analyze these indexes separately.

However, with the current implementation, we only analyze one index at a time, which means the second index will be missed.

In this PR, I’ve checked the analyze version to ensure proper handling. The lower versions don’t have this issue because we can analyze the second index after rebuilding the entire priority queue.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Nov 11, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Nov 11, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 11, 2024
Copy link

ti-chi-bot bot commented Nov 11, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-11 08:14:01.72470307 +0000 UTC m=+257603.915572063: ☑️ agreed by Rustin170506.
  • 2024-11-11 08:18:04.343932786 +0000 UTC m=+257846.534801781: ☑️ agreed by AilinKid.

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 34.61538% with 17 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.5@02f4a28). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.5     #57286   +/-   ##
================================================
  Coverage               ?   56.3723%           
================================================
  Files                  ?       1778           
  Lines                  ?     635065           
  Branches               ?          0           
================================================
  Hits                   ?     358001           
  Misses                 ?     252873           
  Partials               ?      24191           
Flag Coverage Δ
integration 37.0438% <0.0000%> (?)
unit 72.5565% <34.6153%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 52.6135% <0.0000%> (?)

@Rustin170506
Copy link
Member

/retest

Copy link
Contributor

@elsa0520 elsa0520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Nov 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, elsa0520, Rustin170506

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit b7ce927 into pingcap:release-8.5 Nov 11, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants