Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Make use of the upperBound of ticlient's kv_scan interface to ensure no overbound scan will happen (#8081) #8257

Merged

Conversation

MyonKeminta
Copy link
Contributor

What problem does this PR solve?

This PR cherry-picks #8081 (09c6bff) to release-2.1 branch.
This PR should be merged after merging #8247
This fixes in some conditions the kv_scan goes to a deleted range, which may make tikv panic

What is changed and how it works?

This PR cherry-picks #8081 to release-2.1 branch.

Check List

  • Unit test
  • Integration test

Code changes

  • None of those listed

Side effects

  • Not compatible with old version of TiKV.

Related changes

  • Need to be included in the release note

@MyonKeminta
Copy link
Contributor Author

/run-all-tests pd=release-2.1 tikv=pr/3749 tidb-test=release-2.1

@MyonKeminta
Copy link
Contributor Author

/run-all-tests pd=release-2.1 tikv=release-2.1 tidb-test=release-2.1

@zz-jason zz-jason added priority/release-blocker This issue blocks a release. Please solve it ASAP. component/tikv type/2.1 cherry-pick labels Nov 10, 2018
@zz-jason zz-jason changed the title [DNM] [release-2.1] cherry-pick: avoid kv_scan out of bound *: Make use of the upperBound of ticlient's kv_scan interface to ensure no overbound scan will happen (#8081) Nov 10, 2018
@shenli
Copy link
Member

shenli commented Nov 10, 2018

/run-all-tests pd=release-2.1 tikv=release-2.1 tidb-test=release-2.1

@zz-jason
Copy link
Member

@MyonKeminta please resolve conflicts.

@MyonKeminta
Copy link
Contributor Author

/run-all-tests pd=release-2.1 tikv=release-2.1 tidb-test=release-2.1

@MyonKeminta
Copy link
Contributor Author

What's happening on the unit test..

@MyonKeminta
Copy link
Contributor Author

/run-unit-test

@zz-jason
Copy link
Member

LGTM

Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit 21330da into pingcap:release-2.1 Nov 12, 2018
@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. status/all tests passed labels Nov 12, 2018
@MyonKeminta MyonKeminta deleted the misono/cherry-pick-scan-upperbound branch November 12, 2018 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/tikv priority/release-blocker This issue blocks a release. Please solve it ASAP. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants