-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor, cmd: refine HashJoinExec for specific JoinType if outer/inner is nil #8296
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
.gitignore
Outdated
@@ -14,3 +14,4 @@ explain_test | |||
cmd/explaintest/explain-test.out | |||
_tools/ | |||
*.fail.go | |||
cmd/explaintest/explaintest_tidb-server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's better to put this together with cmd/explaintest/explain-test.out
please fix ci. |
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-common-test |
@XuHuaiyu This PR needs to be cherry-picked to release-2.1 branch |
What problem does this PR solve?
inner table is nil
for InnerJoin and SemiJoin.outer table is nil
for all the join types.What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
release-2.1