Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor, cmd: refine HashJoinExec for specific JoinType if outer/inner is nil (#8296) #8315

Merged
merged 4 commits into from
Nov 15, 2018
Merged

executor, cmd: refine HashJoinExec for specific JoinType if outer/inner is nil (#8296) #8315

merged 4 commits into from
Nov 15, 2018

Conversation

XuHuaiyu
Copy link
Contributor

cherry-pick #8296

@XuHuaiyu XuHuaiyu added type/enhancement The issue or PR belongs to an enhancement. type/2.1 cherry-pick labels Nov 14, 2018
@XuHuaiyu
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@zz-jason
Copy link
Member

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 14, 2018
winoros
winoros reviewed Nov 14, 2018
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zz-jason
Copy link
Member

@XuHuaiyu CI failed:

----------------------------------------------------------------------
FAIL: join_test.go:925: testSuite.TestHashJoin

join_test.go:961:
    c.Assert(len(row), Equals, 5)
... obtained int = 7
... expected int = 5

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 15, 2018
@XuHuaiyu
Copy link
Contributor Author

release-2.1 does not contain this commit #7842.
So the plan of not exists is different from the master branch.

@XuHuaiyu
Copy link
Contributor Author

/run-unit-test tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@zz-jason
Copy link
Member

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@crazycs520
Copy link
Contributor

Maybe merge this cherry pick first. #8331

@zz-jason
Copy link
Member

/run-unit-test

@zz-jason zz-jason merged commit 9eb47a8 into pingcap:release-2.1 Nov 15, 2018
@XuHuaiyu XuHuaiyu deleted the release-2.1 branch November 16, 2018 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros left review comments

@zz-jason zz-jason zz-jason approved these changes

Assignees
No one assigned
Labels
status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@XuHuaiyu @zz-jason @crazycs520 @winoros