-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: handle corrupted length in uncompress builtin function #8586
expression: handle corrupted length in uncompress builtin function #8586
Conversation
Hi contributor, thanks for your PR. This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically. |
36702cd
to
d43bb87
Compare
PTAL @zimulala |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
Are there any problems blocking this PR? |
@ziyi-yan Could you help us cherry-pick this commit to release-2.1 and release-2.0? |
@zz-jason I would love to do it. But what am I supposed to do exactly? (I am not an experienced contributor yet.) |
Yes, that's right. Feel free to ask if you encountered any problem. 😄 |
What problem does this PR solve?
fixes #8578
What is changed and how it works?
Returns nil with warning when the length in first four bytes is less than the length of the returned string.
While fixing this issue, I change the error class of
errZlibZData
fromClassTypes
toClassExpression
in order to display their SQL error codes correctly.Check List
Tests
Related changes
This change is